Page MenuHomePhabricator

Give bin/storage some replica-aware options
ClosedPublic

Authored by epriestley on Apr 14 2016, 6:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 16, 11:34 PM
Unknown Object (File)
Fri, Mar 8, 2:07 PM
Unknown Object (File)
Feb 16 2024, 4:33 PM
Unknown Object (File)
Feb 16 2024, 10:02 AM
Unknown Object (File)
Feb 16 2024, 9:17 AM
Unknown Object (File)
Feb 15 2024, 11:47 AM
Unknown Object (File)
Feb 14 2024, 11:29 PM
Unknown Object (File)
Feb 14 2024, 11:28 PM
Subscribers
None

Details

Summary

Fixes T10758.

  • Adds a "--host" flag. If you specify this, we read your cluster config. This lets you dump from a replica.
  • Adds a "--for-replica" flag to storage dump. This makes mysqldump include a CHANGE MASTER ... statement in the output, which is useful when setting up a replica for the first time.
Test Plan
  • Dumped master and replica cluster databases.
  • Dumped non-cluster databases.
  • Ran various other commands (help, status, etc).

Diff Detail

Repository
rP Phabricator
Branch
readonly20
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11731
Build 14696: Run Core Tests
Build 14695: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Give bin/storage some replica-aware options.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2016, 8:23 PM
This revision was automatically updated to reflect the committed changes.