Page MenuHomePhabricator
Differential D15714

Give bin/storage some replica-aware options
ClosedPublic
Actions

Authored by epriestley on Apr 14 2016, 6:44 PM.
Tags
None
Referenced Files
F18905259: D15714.id37862.diff
Sat, Nov 8, 1:31 PM
F18893534: D15714.id37865.diff
Fri, Nov 7, 12:58 PM
F18864037: D15714.diff
Mon, Nov 3, 2:18 AM
F18817101: D15714.id37865.diff
Oct 21 2025, 12:22 PM
F18805709: D15714.diff
Oct 18 2025, 4:12 PM
F18651375: D15714.id.diff
Sep 21 2025, 4:08 AM
F18611520: D15714.diff
Sep 14 2025, 7:23 AM
F18610628: D15714.id37862.diff
Sep 14 2025, 5:14 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10758: Make `bin/storage dump` replica-aware
Commits
rP5a0b7398cabd: Give bin/storage some replica-aware options
Summary

Fixes T10758.

  • Adds a "--host" flag. If you specify this, we read your cluster config. This lets you dump from a replica.
  • Adds a "--for-replica" flag to storage dump. This makes mysqldump include a CHANGE MASTER ... statement in the output, which is useful when setting up a replica for the first time.
Test Plan
  • Dumped master and replica cluster databases.
  • Dumped non-cluster databases.
  • Ran various other commands (help, status, etc).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37862.Apr 14 2016, 6:44 PM
epriestley retitled this revision from to Give bin/storage some replica-aware options.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10758: Make `bin/storage dump` replica-aware.
chad accepted this revision.Apr 14 2016, 8:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2016, 8:23 PM
Closed by commit rP5a0b7398cabd: Give bin/storage some replica-aware options (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2016, 8:23 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 15 2016, 12:09 AM

Revision Contents
Changeset List

PathSize
scripts/
sql/
41 lines
src/
docs/
user/
cluster/
13 lines
infrastructure/
storage/
management/
workflow/
59 lines

Diff 37865

View Options

scripts/sql/manage_storage.php

Loading...
View Options

src/docs/user/cluster/cluster_databases.diviner

Loading...
View Options

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php

Loading...
Phabricator · Built by Phacility