Page MenuHomePhabricator

Give bin/storage some replica-aware options
ClosedPublic

Authored by epriestley on Apr 14 2016, 6:44 PM.
Tags
None
Referenced Files
F14883423: D15714.id37865.diff
Sun, Feb 9, 1:18 AM
F14883422: D15714.id37862.diff
Sun, Feb 9, 1:18 AM
Unknown Object (File)
Sat, Feb 8, 3:00 AM
Unknown Object (File)
Mon, Feb 3, 3:12 AM
Unknown Object (File)
Sun, Feb 2, 8:49 PM
Unknown Object (File)
Sun, Feb 2, 2:36 AM
Unknown Object (File)
Thu, Jan 30, 1:56 PM
Unknown Object (File)
Sun, Jan 26, 11:38 PM
Subscribers
None

Details

Summary

Fixes T10758.

  • Adds a "--host" flag. If you specify this, we read your cluster config. This lets you dump from a replica.
  • Adds a "--for-replica" flag to storage dump. This makes mysqldump include a CHANGE MASTER ... statement in the output, which is useful when setting up a replica for the first time.
Test Plan
  • Dumped master and replica cluster databases.
  • Dumped non-cluster databases.
  • Ran various other commands (help, status, etc).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give bin/storage some replica-aware options.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2016, 8:23 PM
This revision was automatically updated to reflect the committed changes.