Paths

Table of Contentst

Differential D15714

Give bin/storage some replica-aware options
ClosedPublic
Actions

Authored by epriestley on Apr 14 2016, 6:44 PM.

Tags

None

Referenced Files

	F15525311: D15714.diff
	Mon, Apr 21, 1:31 PM

	F15524108: D15714.id.diff
	Mon, Apr 21, 6:01 AM

	F15524107: D15714.id37865.diff
	Mon, Apr 21, 6:01 AM

	F15512125: D15714.diff
	Thu, Apr 17, 8:27 AM

	F15489452: D15714.id37862.diff
	Fri, Apr 11, 9:16 AM

	F15486459: D15714.id37865.diff
	Thu, Apr 10, 7:15 AM

	F15480891: D15714.id.diff
	Tue, Apr 8, 5:09 PM

	F15480795: D15714.id.diff
	Tue, Apr 8, 4:30 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10758: Make `bin/storage dump` replica-aware

Commits

rP5a0b7398cabd: Give bin/storage some replica-aware options

Summary

Fixes T10758.

Adds a "--host" flag. If you specify this, we read your cluster config. This lets you dump from a replica.
Adds a "--for-replica" flag to storage dump. This makes mysqldump include a CHANGE MASTER ... statement in the output, which is useful when setting up a replica for the first time.

Test Plan

Dumped master and replica cluster databases.
Dumped non-cluster databases.
Ran various other commands (help, status, etc).

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37862.Apr 14 2016, 6:44 PM

epriestley retitled this revision from to Give bin/storage some replica-aware options.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10758: Make `bin/storage dump` replica-aware.

chad accepted this revision.Apr 14 2016, 8:23 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 14 2016, 8:23 PM

Closed by commit rP5a0b7398cabd: Give bin/storage some replica-aware options (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2016, 8:23 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 15 2016, 12:09 AM

Revision Contents
Changeset List

Path

Size

scripts/

sql/

manage_storage.php

41 lines

src/

docs/

user/

cluster/

cluster_databases.diviner

13 lines

infrastructure/

storage/

management/

workflow/

PhabricatorStorageManagementDumpWorkflow.php

59 lines

Diff 37865

scripts/sql/manage_storage.php

Loading...

src/docs/user/cluster/cluster_databases.diviner

Loading...

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php

Loading...