Page MenuHomePhabricator
Differential D15712

When proxying the SVN protocol, don't mutate URIs in protocol frames if we're an intracluster proxy
ClosedPublic
Actions

Authored by epriestley on Apr 14 2016, 5:10 PM.
Tags
None
Referenced Files
F13087370: D15712.diff
Thu, Apr 25, 12:57 AM
Unknown Object (File)
Sun, Apr 21, 7:43 PM
Unknown Object (File)
Thu, Apr 11, 12:33 PM
Unknown Object (File)
Tue, Apr 2, 2:02 AM
Unknown Object (File)
Sun, Mar 31, 4:12 PM
Unknown Object (File)
Mar 5 2024, 6:12 PM
Unknown Object (File)
Mar 5 2024, 6:12 PM
Unknown Object (File)
Mar 5 2024, 4:47 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10809: SVN service proxying in Phacility cluster can fail in a couple of ways
Commits
rPca6da4c2befe: When proxying the SVN protocol, don't mutate URIs in protocol frames if we're…
Summary

Ref T10809. Currently, both the proxy and target may mutate URIs (rewriting "svn+ssh://x/diffusion/Y/" to a path on disk).

I believe this previously worked by fate/chance/luck since both URI variants contain the repository information, but the algorithms were tightened up recently with callsign removal.

Stop rewriting them if we're the intracluster proxy -- they only need to be rewritten on the target host.

Test Plan
  • Checked out a proxied SVN repository, with and without a callsign.
  • Checked out an unproxied SVN repository, with and without a callsign.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37855.Apr 14 2016, 5:10 PM
epriestley retitled this revision from to When proxying the SVN protocol, don't mutate URIs in protocol frames if we're an intracluster proxy.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10809: SVN service proxying in Phacility cluster can fail in a couple of ways.
chad accepted this revision.Apr 14 2016, 5:14 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2016, 5:14 PM
Closed by commit rPca6da4c2befe: When proxying the SVN protocol, don't mutate URIs in protocol frames if we're… (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2016, 5:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
ssh/
10 lines

Diff 37856

View Options

src/applications/diffusion/ssh/DiffusionSubversionServeSSHWorkflow.php

Loading...
Phabricator · Built by Phacility