Page MenuHomePhabricator

Add a `cluster.read-only` option
ClosedPublic

Authored by epriestley on Apr 8 2016, 10:41 PM.
Tags
None
Referenced Files
F18759686: D15662.id.diff
Mon, Oct 6, 5:21 AM
F18597454: D15662.id.diff
Sat, Sep 13, 2:55 AM
F18507448: D15662.id.diff
Sep 5 2025, 2:12 AM
F18385339: D15662.id37755.diff
Aug 29 2025, 1:07 AM
F18375037: D15662.id37746.diff
Aug 28 2025, 9:25 AM
F18370161: D15662.id37746.diff
Aug 28 2025, 3:18 AM
F18369838: D15662.diff
Aug 28 2025, 2:46 AM
F18369727: D15662.diff
Aug 28 2025, 2:37 AM
Subscribers
None

Details

Summary

Ref T4571. There will be a very long path beyond this, but add a basic read-only mode. You can explicitly enable this to put Phabricator in a sort of "maintenance" mode today if you're swapping databases or something.

In the long term, we'll automatically degrade into this mode if the master database is down.

Test Plan
  • Enabled read-only mode.
  • Browsed around.
  • Didn't immediately see anything that was totally 100% broken.

Most stuff is 80-90% broken right now. For example:

  • Stuff like submitting comments doesn't work, and gives you a confusing, unhelpful error.
  • None of the UI really knows that it's read-only. EditEngine stuff should all hide itself and say "you can't add new comments while an install is in read-only mode", for example, but currently does not.

Diff Detail

Repository
rP Phabricator
Branch
readonly2
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningwebroot/rsrc/js/core/behavior-read-only-warning.js:1JAVELIN5`javelinsymbols` Not In Path
Advicesrc/infrastructure/storage/lisk/PhabricatorLiskDAO.php:82XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 11608
Build 14515: Run Core Tests
Build 14514: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Add a `cluster.read-only` option.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 9 2016, 3:31 PM
This revision was automatically updated to reflect the committed changes.