Differential D15662

Add a `cluster.read-only` option
ClosedPublic
Actions

Authored by epriestley on Apr 8 2016, 10:41 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 24, 3:47 AM

	Unknown Object (File)
	Fri, Dec 20, 8:00 PM

	Unknown Object (File)
	Sat, Dec 14, 8:21 PM

	Unknown Object (File)
	Fri, Dec 13, 2:08 PM

	Unknown Object (File)
	Thu, Dec 12, 4:37 AM

	Unknown Object (File)
	Thu, Dec 12, 4:37 AM

	Unknown Object (File)
	Thu, Dec 12, 4:37 AM

	Unknown Object (File)
	Thu, Dec 12, 4:17 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T4571: Allow Phabricator to run in Read-Only Mode

Commits

rP49d93dcf98aa: Add a `cluster.read-only` option

Summary

Ref T4571. There will be a very long path beyond this, but add a basic read-only mode. You can explicitly enable this to put Phabricator in a sort of "maintenance" mode today if you're swapping databases or something.

In the long term, we'll automatically degrade into this mode if the master database is down.

Test Plan

Enabled read-only mode.
Browsed around.
Didn't immediately see anything that was totally 100% broken.

Most stuff is 80-90% broken right now. For example:

Stuff like submitting comments doesn't work, and gives you a confusing, unhelpful error.
None of the UI really knows that it's read-only. EditEngine stuff should all hide itself and say "you can't add new comments while an install is in read-only mode", for example, but currently does not.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37746.Apr 8 2016, 10:41 PM

epriestley retitled this revision from to Add a `cluster.read-only` option.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4571: Allow Phabricator to run in Read-Only Mode.

Herald edited edge metadata. · View Herald TranscriptApr 8 2016, 10:41 PM

chad accepted this revision.Apr 9 2016, 3:31 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 9 2016, 3:31 PM

Closed by commit rP49d93dcf98aa: Add a `cluster.read-only` option (authored by epriestley, committed by epriestley). · Explain WhyApr 9 2016, 8:40 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10751: Make Phabricator Highly Available.Apr 10 2016, 4:00 AM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

1 line

src/

applications/

cache/

PhabricatorKeyValueDatabaseCache.php

30 lines

config/

option/

PhabricatorClusterConfigOptions.php

16 lines

multimeter/

data/

MultimeterControl.php

4 lines

notification/

storage/

PhabricatorFeedStoryNotification.php

4 lines

infrastructure/

env/

PhabricatorEnv.php

13 lines

storage/

lisk/

PhabricatorLiskDAO.php

21 lines

management/

workflow/

PhabricatorStorageManagementWorkflow.php

11 lines

testing/

PhabricatorTestCase.php

2 lines

view/

page/

PhabricatorStandardPageView.php

8 lines

webroot/

rsrc/

css/

aphront/

notification.css

5 lines

js/

core/

behavior-read-only-warning.js

16 lines

Diff 37755

resources/celerity/packages.php

Loading...

src/applications/cache/PhabricatorKeyValueDatabaseCache.php

Loading...

src/applications/config/option/PhabricatorClusterConfigOptions.php

Loading...

src/applications/multimeter/data/MultimeterControl.php

Loading...

src/applications/notification/storage/PhabricatorFeedStoryNotification.php

Loading...

src/infrastructure/env/PhabricatorEnv.php

Loading...

src/infrastructure/storage/lisk/PhabricatorLiskDAO.php

Loading...

src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php

Loading...

src/infrastructure/testing/PhabricatorTestCase.php

Loading...

src/view/page/PhabricatorStandardPageView.php

Loading...

webroot/rsrc/css/aphront/notification.css

Loading...

webroot/rsrc/js/core/behavior-read-only-warning.js

Loading...