Fix getInterestingMoves() fatal?
ClosedPublic
Actions

Authored by epriestley on Apr 6 2016, 10:57 PM.

Tags

None

Referenced Files

	F15583180: D15648.diff
	Wed, May 7, 8:09 PM

	F15486979: D15648.diff
	Apr 10 2025, 10:21 AM

	F15473677: D15648.id37709.diff
	Apr 6 2025, 12:35 AM

	F15463603: D15648.id37708.diff
	Apr 2 2025, 1:21 AM

	F15452832: D15648.diff
	Mar 29 2025, 7:36 AM

	F15450478: D15648.id.diff
	Mar 28 2025, 3:54 PM

	F15421932: D15648.id.diff
	Mar 22 2025, 3:43 AM

	F15420151: D15648.id37709.diff
	Mar 21 2025, 11:49 AM

View All Files

Subscribers

None

Details

Reviewers

chad

Maniphest Tasks

T10740: getInterestingMoves() fatal on tasks with custom field transactions for no-longer-valid custom fields

Commits

rP0650f725f1f0: Fix getInterestingMoves() fatal?

Summary

Fixes T10740. Probably?

Test Plan

No you

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37708.Apr 6 2016, 10:57 PM

epriestley retitled this revision from to Fix getInterestingMoves() fatal?.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10740: getInterestingMoves() fatal on tasks with custom field transactions for no-longer-valid custom fields.

Yep, no more fatals.

This revision is now accepted and ready to land.Apr 6 2016, 11:00 PM

Cool, thanks for catching this!

Closed by commit rP0650f725f1f0: Fix getInterestingMoves() fatal? (authored by epriestley, committed by epriestley). · Explain WhyApr 6 2016, 11:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

storage/

PhabricatorApplicationTransaction.php

1 line

Diff 37709

View Options

src/applications/transactions/storage/PhabricatorApplicationTransaction.php

Fix getInterestingMoves() fatal?ClosedPublicActions