Page MenuHomePhabricator
Differential D15640

Fix some issue with "Move on Workboard" and workboard-less or invisible projects
ClosedPublic
Actions

Authored by epriestley on Apr 6 2016, 5:08 PM.
Tags
None
Referenced Files
F13083003: D15640.diff
Wed, Apr 24, 10:23 PM
F13079767: D15640.diff
Wed, Apr 24, 1:59 AM
Unknown Object (File)
Fri, Apr 19, 2:26 AM
Unknown Object (File)
Fri, Apr 19, 2:26 AM
Unknown Object (File)
Fri, Apr 19, 2:26 AM
Unknown Object (File)
Fri, Apr 19, 2:26 AM
Unknown Object (File)
Mon, Apr 15, 7:25 AM
Unknown Object (File)
Thu, Apr 11, 7:33 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10734: "Call to a member function getProject() on a non-object" when clicking on a ticket on secure.phabricator.com
T6027: Way to edit which column a task is in from the task itself
Commits
rP2ae8e57cf110: Fix some issue with "Move on Workboard" and workboard-less or invisible projects
Summary

Ref T6027. Fixes T10734.

  • If one of the projects a task is tagged with isn't visible to the user or doesn't have a board, it won't have columns.
  • Don't show options for projects with disabled boards.
Test Plan
  • Viewed task with project with no columns; no fatal.
  • Viewed task with project with disabled board; no options to move on that board.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37687.Apr 6 2016, 5:08 PM
epriestley updated this revision to Diff 37688.
epriestley retitled this revision from to Fix some issue with "Move on Workboard" and workboard-less or invisible projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T6027: Way to edit which column a task is in from the task itself.
  • Slightly cleaner fix for disabled boards.
epriestley mentioned this in Z1336: General Chat.Apr 6 2016, 5:40 PM
eadler added a task: T10734: "Call to a member function getProject() on a non-object" when clicking on a ticket on secure.phabricator.com.Apr 6 2016, 6:01 PM
epriestley updated this object.Apr 6 2016, 6:02 PM
chad accepted this revision.Apr 6 2016, 6:04 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2016, 6:04 PM
chad added a comment.Apr 6 2016, 6:04 PM

Sorry, went to farmers market.

epriestley added a comment.Apr 6 2016, 6:05 PM

Get anything good? 🍆

(eggplants are gross I just don't know how many other vegetable emoji there are)

Closed by commit rP2ae8e57cf110: Fix some issue with "Move on Workboard" and workboard-less or invisible projects (authored by epriestley, committed by epriestley). · Explain WhyApr 6 2016, 6:05 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Apr 6 2016, 6:12 PM

No winter vegetables were available to purchase. Just some fruits.

epriestley added a comment.Apr 6 2016, 6:13 PM

Fruits like EAR OF MAIZE? 🌽

chad added a comment.Apr 6 2016, 6:14 PM

There was something green at one of the stands but I thought maybe someone just was selling their grass clippings? I dunno.

epriestley added a comment.Apr 6 2016, 6:14 PM

Free-range grass clippings, no doubt.

Revision Contents
Changeset List

PathSize
src/
applications/
maniphest/
editor/
11 lines

Diff 37689

View Options

src/applications/maniphest/editor/ManiphestEditEngine.php

Loading...
Phabricator · Built by Phacility