Page MenuHomePhabricator

Fix some issue with "Move on Workboard" and workboard-less or invisible projects
ClosedPublic

Authored by epriestley on Apr 6 2016, 5:08 PM.

Details

Summary

Ref T6027. Fixes T10734.

  • If one of the projects a task is tagged with isn't visible to the user or doesn't have a board, it won't have columns.
  • Don't show options for projects with disabled boards.
Test Plan
  • Viewed task with project with no columns; no fatal.
  • Viewed task with project with disabled board; no options to move on that board.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37688.
epriestley retitled this revision from to Fix some issue with "Move on Workboard" and workboard-less or invisible projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
  • Slightly cleaner fix for disabled boards.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2016, 6:04 PM

Sorry, went to farmers market.

Get anything good? ๐Ÿ†

(eggplants are gross I just don't know how many other vegetable emoji there are)

This revision was automatically updated to reflect the committed changes.

No winter vegetables were available to purchase. Just some fruits.

Fruits like EAR OF MAIZE? ๐ŸŒฝ

There was something green at one of the stands but I thought maybe someone just was selling their grass clippings? I dunno.

Free-range grass clippings, no doubt.