Page MenuHomePhabricator
Differential D15620

Allow OAuth applications to be disabled instead of destroyed
ClosedPublic
Actions

Authored by epriestley on Apr 5 2016, 5:15 PM.
Tags
None
Referenced Files
F15506993: D15620.diff
Tue, Apr 15, 3:40 PM
F15450732: D15620.id37643.diff
Fri, Mar 28, 5:48 PM
F15436431: D15620.id.diff
Tue, Mar 25, 2:05 PM
F15431790: D15620.diff
Mon, Mar 24, 2:32 PM
F15407502: D15620.id37643.diff
Tue, Mar 18, 5:53 PM
F15396181: D15620.diff
Mar 16 2025, 12:32 PM
F15395252: D15620.id37653.diff
Mar 16 2025, 4:24 AM
Unknown Object (File)
Feb 16 2025, 6:36 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T7303: Provide OAuth access to Conduit
Commits
rP8dfc7d4201fd: Allow OAuth applications to be disabled instead of destroyed
Summary

Ref T7303. This interaction is very oldschool; modernize it to enable/disable instead of "nuke from orbit".

Test Plan
  • Enabled applications.
  • Disabled applications.
  • Viewed applications in list view.
  • Generated new tokens.
  • Tried to use a token from a disabled application (got rebuffed).
  • Tried to use a token from an enabled application (worked fine).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37643.Apr 5 2016, 5:15 PM
epriestley retitled this revision from to Allow OAuth applications to be disabled instead of destroyed.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T7303: Provide OAuth access to Conduit.
chad accepted this revision.Apr 5 2016, 5:30 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 5 2016, 5:30 PM
Closed by commit rP8dfc7d4201fd: Allow OAuth applications to be disabled instead of destroyed (authored by epriestley, committed by epriestley). · Explain WhyApr 5 2016, 8:22 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37653

View Options

resources/sql/autopatches/20160405.oauth.2.disable.sql

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/oauthserver/PhabricatorOAuthServer.php

Loading...
View Options

src/applications/oauthserver/application/PhabricatorOAuthServerApplication.php

Loading...
View Options

src/applications/oauthserver/controller/PhabricatorOAuthServerAuthController.php

Loading...
View Options

src/applications/oauthserver/controller/PhabricatorOAuthServerTokenController.php

Loading...
View Options

src/applications/oauthserver/controller/client/PhabricatorOAuthClientDeleteController.php

Loading...
View Options

src/applications/oauthserver/controller/client/PhabricatorOAuthClientDisableController.php

Loading...
View Options

src/applications/oauthserver/controller/client/PhabricatorOAuthClientTestController.php

Loading...
View Options

src/applications/oauthserver/controller/client/PhabricatorOAuthClientViewController.php

Loading...
View Options

src/applications/oauthserver/editor/PhabricatorOAuthServerEditor.php

Loading...
View Options

src/applications/oauthserver/query/PhabricatorOAuthServerClientSearchEngine.php

Loading...
View Options

src/applications/oauthserver/storage/PhabricatorOAuthServerClient.php

Loading...
View Options

src/applications/oauthserver/storage/PhabricatorOAuthServerTransaction.php

Loading...
Phabricator · Built by Phacility