Page MenuHomePhabricator

Allow OAuth applications to be disabled instead of destroyed

Authored by epriestley on Apr 5 2016, 5:15 PM.



Ref T7303. This interaction is very oldschool; modernize it to enable/disable instead of "nuke from orbit".

Test Plan
  • Enabled applications.
  • Disabled applications.
  • Viewed applications in list view.
  • Generated new tokens.
  • Tried to use a token from a disabled application (got rebuffed).
  • Tried to use a token from an enabled application (worked fine).

Diff Detail

rP Phabricator
Lint OK
Unit Tests OK
Build Status
Buildable 11510
Build 14365: Run Core Tests
Build 14364: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37643.Apr 5 2016, 5:15 PM
epriestley retitled this revision from to Allow OAuth applications to be disabled instead of destroyed.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Apr 5 2016, 5:30 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 5 2016, 5:30 PM
This revision was automatically updated to reflect the committed changes.