Page MenuHomePhabricator
Differential D15607

Fix resolution of commits in SVN repositories without callsigns
ClosedPublic
Actions

Authored by epriestley on Apr 4 2016, 4:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 13, 3:04 AM
Unknown Object (File)
Thu, Sep 12, 8:25 AM
Unknown Object (File)
Mon, Sep 9, 3:06 PM
Unknown Object (File)
Mon, Sep 9, 9:14 AM
Unknown Object (File)
Thu, Sep 5, 7:05 PM
Unknown Object (File)
Sun, Sep 1, 12:11 PM
Unknown Object (File)
Sat, Aug 31, 5:56 PM
Unknown Object (File)
Wed, Aug 28, 10:55 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10721: SVN repositories with no callsigns do not route individual commit URLs properly
Commits
rPb07a524b4b07: Fix resolution of commits in SVN repositories without callsigns
Summary

Fixes T10721. When trying to load commits by identifier, we would take some bad pathways in Subversion if the repository had no callsign and end up missing the commits.

Fix this logic so it works for either callsigns (e.g., if passed rXyyy) or with PHIDs if passed repositories.

Test Plan
  • Viewed SVN commit in a Subversion repository with no callsign.
  • Added a callsign, looked at it again.
  • Viewed non-SVN commits in callsign and non-callsign repositories.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37616.Apr 4 2016, 4:43 PM
epriestley retitled this revision from to Fix resolution of commits in SVN repositories without callsigns.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10721: SVN repositories with no callsigns do not route individual commit URLs properly.
chad accepted this revision.Apr 4 2016, 4:44 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 4 2016, 4:44 PM
Closed by commit rPb07a524b4b07: Fix resolution of commits in SVN repositories without callsigns (authored by epriestley, committed by epriestley). · Explain WhyApr 4 2016, 4:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
query/
11 lines

Diff 37617

View Options

src/applications/diffusion/query/DiffusionCommitQuery.php

Loading...
Phabricator · Built by Phacility