Differential D15566

Fix javascript interaction with right-hand-side images in two-up diff views in Differential
ClosedPublic
Actions

Authored by epriestley on Apr 1 2016, 7:53 PM.

Details

Reviewers

chad

Maniphest Tasks

T10704: Comments on images in Differential (Right Side) cause JS error

Commits

rP61301ead90e4: Fix javascript interaction with right-hand-side images in two-up diff views…

Summary

Fixes T10704. This is just bad copy-paste -- "O" for "old" should be "N" for "new".

Test Plan

Followed steps on T10704.
Applied patch.
Marked inline done, replied, etc. No more JS errors.

Diff Detail

Repository

rP Phabricator

Branch

inline1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11393
Build 14191: Run Core Tests
Build 14190: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37528.Apr 1 2016, 7:53 PM

epriestley retitled this revision from to Fix javascript interaction with right-hand-side images in two-up diff views in Differential.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10704: Comments on images in Differential (Right Side) cause JS error.

chad accepted this revision.Apr 1 2016, 7:54 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 1 2016, 7:54 PM

Closed by commit rP61301ead90e4: Fix javascript interaction with right-hand-side images in two-up diff views… (authored by epriestley, committed by epriestley). · Explain WhyApr 1 2016, 7:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

render/

DifferentialChangesetTwoUpRenderer.php

2 lines

Diff 37528

View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Fix javascript interaction with right-hand-side images in two-up diff views in DifferentialClosedPublicActions