Page MenuHomePhabricator

Don't show continuation lines in "stacked action" comment previews
ClosedPublic

Authored by epriestley on Apr 1 2016, 1:06 PM.
Tags
None
Referenced Files
F14100059: D15562.diff
Tue, Nov 26, 1:18 PM
Unknown Object (File)
Mon, Nov 25, 10:00 AM
Unknown Object (File)
Sun, Nov 24, 10:52 AM
Unknown Object (File)
Tue, Nov 12, 7:10 AM
Unknown Object (File)
Mon, Nov 11, 6:36 AM
Unknown Object (File)
Sat, Nov 9, 11:43 AM
Unknown Object (File)
Sat, Nov 9, 11:43 AM
Unknown Object (File)
Sat, Nov 9, 11:43 AM
Subscribers
None

Details

Summary

Ref T10698. Currently, we show the spacer/continuation lines around previews, but these don't make sense in previews.

(Other stuff also uses this code so I can't simply remove spacer.)

Test Plan

Before:

Screen Shot 2016-04-01 at 6.05.19 AM.png (248×168 px, 13 KB)

After:

Screen Shot 2016-04-01 at 6.05.26 AM.png (224×216 px, 18 KB)

Diff Detail

Repository
rP Phabricator
Branch
cpreview
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 11380
Build 14172: Run Core Tests
Build 14171: arc lint + arc unit

Unit TestsFailed

TimeTest
178 msPhabricatorCelerityTestCase::Unknown Unit Message ("")
Assertion failed, expected 'true' (at PhabricatorCelerityTestCase.php:32): When this test fails, it means the Celerity resource map is out of date. Run `bin/celerity map` to rebuild it. ACTUAL VALUE
1 msAlmanacNamesTestCase::Unknown Unit Message ("")
30 assertions passed.
0 msAlmanacServiceTypeTestCase::Unknown Unit Message ("")
1 assertion passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
2 assertions passed.
0 msAphrontHTTPSinkTestCase::Unknown Unit Message ("")
3 assertions passed.
View Full Test Results (1 Failed · 312 Passed)

Event Timeline

epriestley retitled this revision from to Don't show continuation lines in "stacked action" comment previews.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad requested changes to this revision.Apr 1 2016, 2:16 PM
chad edited edge metadata.

legumes

This revision now requires changes to proceed.Apr 1 2016, 2:16 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 1 2016, 2:53 PM
This revision was automatically updated to reflect the committed changes.