Page MenuHomePhabricator

Bridge GitHub users into Phabricator and attribute actions to them
ClosedPublic

Authored by epriestley on Mar 28 2016, 7:46 PM.
Tags
None
Referenced Files
F10887520: D15541.id37467.diff
Sat, Jul 2, 12:06 PM
Unknown Object (File)
Wed, Jun 29, 9:43 AM
Unknown Object (File)
Sun, Jun 26, 6:34 AM
Unknown Object (File)
Sat, Jun 25, 11:31 AM
Unknown Object (File)
Sat, Jun 18, 6:10 AM
Unknown Object (File)
Thu, Jun 16, 2:22 AM
Unknown Object (File)
Mon, Jun 13, 3:54 AM
Unknown Object (File)
Sun, Jun 12, 1:28 PM
Subscribers
None

Details

Summary

Ref T10538. Ref T10537. This creates PHIDs which represent GitHub users, and uses them as the actors for synchronized comments.

I've just made them Doorkeeper objects. There are three major kinds of objects they could possibly be:

  • Nuance requestor objects.
  • External account objects.
  • Doorkeeper objects.

I don't think we actually need distinct nuance requestor objects. These don't really do anything right now, and were originally created before Doorkeeper. I think Doorkeeper is a superset of nuance requestor functionality, and better developed and more flexible.

Likewise, doorkeeper objects are much more flexible than external account objects, and it's nice to imagine that we can import from Twootfeed or whatever without needing to build full OAuth for it. I also like less stuff touching auth code, when possible.

Making these separate from external accounts does make it a bit harder to reconcile external users with internal users, but I think that's OK, and that it's generally desirable to show the real source of a piece of content. That is, if I wrote a comment on GitHub but also have a Phabricator account, I think it's good to show "epriestley (GitHub)" (the GitHub user) as the author, not "epriestley" (the Phabricator user). I think this is generally less confusing overall, and we can add more linkage later to make it clearer.

Test Plan

Screen Shot 2016-03-28 at 12.37.43 PM.png (160×1 px, 20 KB)

Screen Shot 2016-03-28 at 12.37.55 PM.png (245×403 px, 18 KB)

Diff Detail

Repository
rP Phabricator
Branch
nuance28
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/doorkeeper/bridge/DoorkeeperBridgeGitHubUser.php:51XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 11329
Build 14095: Run Core Tests
Build 14094: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Bridge GitHub users into Phabricator and attribute actions to them.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 28 2016, 8:01 PM
This revision was automatically updated to reflect the committed changes.