Page MenuHomePhabricator

Remove dedicated storage for NuanceRequestor
ClosedPublic

Authored by epriestley on Mar 29 2016, 2:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 27, 12:00 PM
Unknown Object (File)
Tue, Jun 14, 4:16 PM
Unknown Object (File)
Mon, Jun 13, 11:53 AM
Unknown Object (File)
Sat, Jun 4, 11:34 AM
Unknown Object (File)
May 27 2022, 9:47 PM
Unknown Object (File)
Apr 15 2017, 3:05 PM
Unknown Object (File)
Apr 11 2017, 2:41 PM
Unknown Object (File)
Mar 13 2017, 8:49 PM
Subscribers
None

Details

Summary

Ref T10537. Currently, Nuance has a NuanceRequestor object, intended to represent the external user who created content (e.g., a GitHub account or a Twitter account or whatever).

This object is currently almost unused, and its design predates Doorkeeper. In D15541, I chose to use doorkeeper objects instead of NuanceRequestor objects to represent requestors.

I don't currently anticipate a need for such an object, given that we have Doorkeeper. If we do need it in the future for some reason, it would be fairly easy to restore it, create a requestor type which wraps a Doorkeeper object, and then migrate. Not super thrilling to do that, but not a huge mess.

NuanceItem still has a requestorPHID, but this is now a less formal object PHID instead of a more formal Requestor-object PHID, and holds a doorkeeper exeternal object PHID for GitHub events.

Test Plan
  • Grepped for nuancerequestor.
  • Ran bin/storage upgrade -f.
  • Grepped for requestor, remaining uses of this term seem reasonable/correct.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Remove dedicated storage for NuanceRequestor.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 29 2016, 3:38 PM
This revision was automatically updated to reflect the committed changes.