Page MenuHomePhabricator

Fully fix a bad rule object aliasing issue custom remarkup rules
ClosedPublic

Authored by epriestley on Mar 28 2016, 5:24 PM.
Tags
None
Referenced Files
F15491765: D15535.id37451.diff
Sat, Apr 12, 7:17 AM
F15489527: D15535.id.diff
Fri, Apr 11, 9:36 AM
F15486789: D15535.diff
Thu, Apr 10, 9:41 AM
F15461133: D15535.diff
Tue, Apr 1, 5:30 AM
F15415030: D15535.diff
Thu, Mar 20, 3:36 AM
F15388275: D15535.diff
Mar 15 2025, 3:34 AM
F15386975: D15535.id37451.diff
Mar 15 2025, 1:35 AM
F15380307: D15535.id.diff
Mar 14 2025, 2:27 AM

Details

Summary

Fixes T10234. This is a more thorough fix.

Root issue is that some time around D13589, we started hitting an object cache for loadCustomInlineRules(), but didn't adjust the code to account for that.

So if a page created multiple similar engines, we'd return the same $rule object for multiple engines, call setEngine() on it with different engines, and then possibly try to render using an already-expired engine the second time through.

Instead, create a separate $rule object for each separate $engine.

Test Plan

Repro is something like this:

  • Create a custominlinerule which uses an engine.
  • Purge the remarkup cache.
  • Load a page which uses the rule in two engines (e.g., in a revision description, and also in an inline comment).
  • Before change: second one could fatal. After change: clean load.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fully fix a bad rule object aliasing issue custom remarkup rules.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
thoughtpolice added a reviewer: thoughtpolice.
thoughtpolice added subscribers: eadler, thoughtpolice.

I've confirmed this fixed our instance of T10234 on phabricator.haskell.org

(/cc @eadler, who may want to note this for Wikimedia?)

I've confirmed this fixed our instance of T10234 on phabricator.haskell.org

(/cc @eadler, who may want to note this for Wikimedia?)

I deal with FreeBSD, my employers, and a few other small instances, but appreciate the CC nonetheless.

chad edited edge metadata.

¯\_(ツ)_/¯

This revision is now accepted and ready to land.Mar 28 2016, 6:20 PM
This revision was automatically updated to reflect the committed changes.