Page MenuHomePhabricator

Add a key to improve Diffusion's cache fill history query
ClosedPublic

Authored by epriestley on Mar 11 2016, 1:36 AM.
Tags
None
Referenced Files
F18436734: D15460.diff
Sun, Aug 31, 11:23 AM
F18141531: D15460.id37257.diff
Thu, Aug 14, 8:56 AM
F18046912: D15460.id37256.diff
Sun, Aug 3, 11:05 AM
F17973687: D15460.id.diff
Aug 1 2025, 4:16 PM
F17945418: D15460.diff
Jul 31 2025, 12:06 PM
Unknown Object (File)
Jul 1 2025, 4:41 PM
Unknown Object (File)
Jun 30 2025, 11:26 AM
Unknown Object (File)
Jun 26 2025, 1:13 PM
Subscribers
None

Details

Summary

Ref T10560. I don't fully understand what MySQL is doing here, but it looks like this key improves the problematic dataset in practice.

(It makes sense that this key helps, I'm just not sure why the two separate keys and the UNION ALL are so bad.)

This key isn't hugely expensive to add, so we can try it and see if there are still issues.

Test Plan

Ran bin/storage adjust, saw key added to table. Used SHOW CREATE TABLE ... to verify the key exists. Used EXPLAIN SELECT ... to make sure MySQL actually uses it.

Diff Detail

Repository
rP Phabricator
Branch
pathkey
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11119
Build 13775: Run Core Tests
Build 13774: arc lint + arc unit