Page MenuHomePhabricator
Differential D15377

Give PHUITwoColumnView an addPropertySection method
ClosedPublic
Actions

Authored by chad on Mar 1 2016, 8:16 PM.
Tags
None
Referenced Files
F14375678: D15377.diff
Fri, Dec 20, 10:45 PM
Unknown Object (File)
Thu, Dec 19, 4:53 AM
Unknown Object (File)
Wed, Dec 18, 1:27 AM
Unknown Object (File)
Sat, Dec 14, 1:03 AM
Unknown Object (File)
Fri, Dec 13, 1:22 AM
Unknown Object (File)
Wed, Nov 27, 5:31 AM
Unknown Object (File)
Wed, Nov 27, 4:24 AM
Unknown Object (File)
Wed, Nov 27, 4:23 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPcaadd1025a1f: Give PHUITwoColumnView an addPropertySection method
Summary

Simplifies building pages a little more, adds a helper method to just add a property section to the main column automatically above other content.

Test Plan

Review Ponder, Herald, Passphrase, Countdown.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 37072.Mar 1 2016, 8:16 PM
chad retitled this revision from to Give PHUITwoColumnView an addPropertySection method.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 1 2016, 8:16 PM
chad added a comment.Mar 2 2016, 5:04 PM

Mind taking a quick peek here? I'd like to simplify some of these calls.

epriestley accepted this revision.Mar 2 2016, 5:09 PM
epriestley edited edge metadata.

Seems fine to me.

This revision is now accepted and ready to land.Mar 2 2016, 5:09 PM
Closed by commit rPcaadd1025a1f: Give PHUITwoColumnView an addPropertySection method (authored by chad, committed by chad). · Explain WhyMar 2 2016, 5:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
controller/
15 lines
passphrase/
controller/
12 lines
ponder/
controller/
13 lines
view/
phui/
39 lines

Diff 37087

View Options

src/applications/herald/controller/HeraldRuleViewController.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseCredentialViewController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionViewController.php

Loading...
View Options

src/view/phui/PHUITwoColumnView.php

Loading...
Phabricator · Built by Phacility