Page MenuHomePhabricator
Differential D15377

Give PHUITwoColumnView an addPropertySection method
ClosedPublic
Actions

Authored by chad on Mar 1 2016, 8:16 PM.
Tags
None
Referenced Files
F13171844: D15377.diff
Tue, May 7, 11:54 AM
F13168699: D15377.diff
Tue, May 7, 7:53 AM
Unknown Object (File)
Fri, May 3, 7:34 AM
Unknown Object (File)
Thu, Apr 25, 1:37 AM
Unknown Object (File)
Fri, Apr 12, 9:17 AM
Unknown Object (File)
Thu, Apr 11, 9:20 AM
Unknown Object (File)
Sun, Apr 7, 7:27 PM
Unknown Object (File)
Apr 4 2024, 10:24 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPcaadd1025a1f: Give PHUITwoColumnView an addPropertySection method
Summary

Simplifies building pages a little more, adds a helper method to just add a property section to the main column automatically above other content.

Test Plan

Review Ponder, Herald, Passphrase, Countdown.

Diff Detail

Repository
rP Phabricator
Branch
phui-two-column-property (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10929
Build 13487: Run Core Tests
Build 13486: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37072.Mar 1 2016, 8:16 PM
chad retitled this revision from to Give PHUITwoColumnView an addPropertySection method.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 1 2016, 8:16 PM
chad added a comment.Mar 2 2016, 5:04 PM

Mind taking a quick peek here? I'd like to simplify some of these calls.

epriestley accepted this revision.Mar 2 2016, 5:09 PM
epriestley edited edge metadata.

Seems fine to me.

This revision is now accepted and ready to land.Mar 2 2016, 5:09 PM
Closed by commit rPcaadd1025a1f: Give PHUITwoColumnView an addPropertySection method (authored by chad, committed by chad). · Explain WhyMar 2 2016, 5:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
controller/
15 lines
passphrase/
controller/
12 lines
ponder/
controller/
13 lines
view/
phui/
39 lines

Diff 37072

View Options

src/applications/herald/controller/HeraldRuleViewController.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseCredentialViewController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionViewController.php

Loading...
View Options

src/view/phui/PHUITwoColumnView.php

Loading...
Phabricator · Built by Phacility