Converts Macro to new layout
Details
Details
- Reviewers
epriestley - Commits
- Restricted Diffusion Commit
rP6f481aa84faf: Convert Macro to PHUITwoColumnView
Add Macro, Edit Macro, Mobile, Desktop layouts
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- macro (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 10945 Build 13509: Run Core Tests Build 13508: arc lint + arc unit
Event Timeline
| src/applications/macro/controller/PhabricatorMacroViewController.php | ||
|---|---|---|
| 143–147 | Is this information already on the Handle somewhere? | |
| src/applications/macro/controller/PhabricatorMacroViewController.php | ||
|---|---|---|
| 143–147 | Yes, $handle->getImageURI(). | |
| src/applications/macro/controller/PhabricatorMacroViewController.php | ||
|---|---|---|
| 143–147 | Is this correct or is there still a cleaner way? I could probably add this to be automatic in PHUITwoColumnView as well with setAttribution | |
| src/applications/macro/controller/PhabricatorMacroViewController.php | ||
|---|---|---|
| 143–147 | Perhaps slightly cleaner as: - $author = $viewer->renderHandle($author_phid)->render(); + $author = $handles[$author_phid]->renderLink(); But pretty much the same thing. | |