Paths

Table of Contentst

Differential D15372

Convert Macro to PHUITwoColumnView
ClosedPublic
Actions

Authored by chad on Mar 1 2016, 4:41 PM.

Tags

None

Referenced Files

	F14310210: D15372.id37089.diff
	Wed, Dec 18, 1:27 AM

	F14310209: D15372.id37088.diff
	Wed, Dec 18, 1:27 AM

	Unknown Object (File)
	Sun, Dec 15, 10:26 PM

	Unknown Object (File)
	Thu, Dec 12, 10:19 AM

	Unknown Object (File)
	Sun, Dec 8, 5:11 AM

	Unknown Object (File)
	Wed, Nov 27, 5:35 AM

	Unknown Object (File)
	Wed, Nov 27, 4:24 AM

	Unknown Object (File)
	Wed, Nov 27, 4:24 AM

Subscribers

Details

Reviewers

Commits

Restricted Diffusion Commit
rP6f481aa84faf: Convert Macro to PHUITwoColumnView

Summary

Converts Macro to new layout

Test Plan

Add Macro, Edit Macro, Mobile, Desktop layouts

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 37065.Mar 1 2016, 4:41 PM

chad retitled this revision from to Convert Macro to PHUITwoColumnView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMar 1 2016, 4:41 PM

chad added inline comments.Mar 1 2016, 5:10 PM

src/applications/macro/controller/PhabricatorMacroViewController.php
143–147	Is this information already on the Handle somewhere?

epriestley accepted this revision.Mar 1 2016, 7:36 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/macro/controller/PhabricatorMacroViewController.php
143–147	Yes, `$handle->getImageURI()`.

This revision is now accepted and ready to land.Mar 1 2016, 7:36 PM

chad planned changes to this revision.Mar 1 2016, 9:14 PM

cleaner code
clean up Macro
test audio

This revision is now accepted and ready to land.Mar 2 2016, 6:17 PM

chad added inline comments.Mar 2 2016, 6:21 PM

src/applications/macro/controller/PhabricatorMacroViewController.php
143–147	Is this correct or is there still a cleaner way? I could probably add this to be automatic in PHUITwoColumnView as well with `setAttribution`

epriestley added inline comments.Mar 2 2016, 6:24 PM

src/applications/macro/controller/PhabricatorMacroViewController.php
143–147	Perhaps slightly cleaner as: - $author = $viewer->renderHandle($author_phid)->render(); + $author = $handles[$author_phid]->renderLink(); But pretty much the same thing.

Closed by commit rP6f481aa84faf: Convert Macro to PHUITwoColumnView (authored by chad, committed by chad). · Explain WhyMar 2 2016, 6:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

controller/

PhabricatorMacroViewController.php

120 lines

Diff 37089

src/applications/macro/controller/PhabricatorMacroViewController.php

Loading...