Differential D15370

Make the libphutil library map test failure more readable
ClosedPublic
Actions

Authored by epriestley on Mar 1 2016, 2:17 PM.

Tags

None

Referenced Files

	F13095504: D15370.id37059.diff
	Thu, Apr 25, 10:10 AM

	F13083754: D15370.diff
	Wed, Apr 24, 10:42 PM

	Unknown Object (File)
	Sat, Apr 20, 3:06 AM

	Unknown Object (File)
	Fri, Apr 19, 4:16 PM

	Unknown Object (File)
	Thu, Apr 11, 7:37 AM

	Unknown Object (File)
	Sun, Apr 7, 7:57 AM

	Unknown Object (File)
	Wed, Apr 3, 1:52 AM

	Unknown Object (File)
	Sun, Mar 31, 5:12 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10457: Improve Harbomaster/Drydock UI/UX before release

Commits

rPHU76425eaa8125: (stable) Promote 2016 Week 10
rPHUad3f475c8c13: Make the libphutil library map test failure more readable

Summary

Ref T10457. This is an upstream quality-of-life fix.

Currently, if the map rebuild test fails it generates about 9,000 lines of output in a huge diff of the two values. This is technically fine, but pretty hard to read.

Instead, compute a smaller difference showing only changed keys, since we never care about the values when this failure occurs (and barely care about the keys).

Test Plan

   FAIL  PhabricatorLibraryTestCase::testLibraryMap
Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`.
These entries differ: class.NewExampleClass.

ACTUAL VALUE
false

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37059.Mar 1 2016, 2:17 PM

epriestley retitled this revision from to Make the libphutil library map test failure more readable.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10457: Improve Harbomaster/Drydock UI/UX before release.

chad accepted this revision.Mar 1 2016, 2:44 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 1 2016, 2:44 PM

Closed by commit rPHUad3f475c8c13: Make the libphutil library map test failure more readable (authored by epriestley, committed by epriestley). · Explain WhyMar 1 2016, 2:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

__tests__/

PhutilLibraryTestCase.php

57 lines

Diff 37060

src/tests/PhutilLibraryTestCase.php

Loading...