Page MenuHomePhabricator

Make the libphutil library map test failure more readable
ClosedPublic

Authored by epriestley on Mar 1 2016, 2:17 PM.

Details

Summary

Ref T10457. This is an upstream quality-of-life fix.

Currently, if the map rebuild test fails it generates about 9,000 lines of output in a huge diff of the two values. This is technically fine, but pretty hard to read.

Instead, compute a smaller difference showing only changed keys, since we never care about the values when this failure occurs (and barely care about the keys).

Test Plan
   FAIL  PhabricatorLibraryTestCase::testLibraryMap
Assertion failed, expected 'true' (at PhutilLibraryTestCase.php:51): The library map is out of date. Rebuild it with `arc liberate`.
These entries differ: class.NewExampleClass.

ACTUAL VALUE
false

Diff Detail

Repository
rPHU libphutil
Branch
dry14
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10899
Build 13450: Run Core Tests
Build 13449: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Make the libphutil library map test failure more readable.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 1 2016, 2:44 PM
This revision was automatically updated to reflect the committed changes.