Page MenuHomePhabricator

Give unit test results their own table in Differential
ClosedPublic

Authored by epriestley on Feb 29 2016, 5:56 PM.

Details

Summary

Ref T10457. This gives unit test results a more first-class treatment in the Differential UI, and consolidates some rendering code.

Test Plan

Before:

Screen Shot 2016-02-29 at 9.53.54 AM.png (1×1 px, 344 KB)

After:

Screen Shot 2016-02-29 at 9.54.02 AM.png (1×1 px, 341 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give unit test results their own table in Differential.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley edited edge metadata.
  • Small fix for legacy messages: only link test results if we're examining a concrete (vs synthetic) result.
src/applications/harbormaster/view/HarbormasterUnitSummaryView.php
73

I believe you can just pass a note to objectbox or aphront table, if I remember right. We use it in Legalpad, and would be a little cleaner layout wise.

pasted_file (242×676 px, 47 KB)

Hmm, it's currently implemented as a <td /> above the first row, which breaks table-layout: fixed:

Screen Shot 2016-02-29 at 12.19.28 PM.png (156×1 px, 31 KB)

epriestley edited edge metadata.
  • Implement setNotice() using a <div /> above the table.
  • Legalpad, etc., still look normal.
  • "Excuse" now looks a little better:

Screen Shot 2016-02-29 at 12.24.10 PM.png (300×634 px, 48 KB)

chad edited edge metadata.

Okies.

This revision is now accepted and ready to land.Feb 29 2016, 8:25 PM
This revision was automatically updated to reflect the committed changes.