Page MenuHomePhabricator

Don't publish anything for "Disable Mail" / "Enable Mail" on projects
ClosedPublic

Authored by epriestley on Feb 29 2016, 12:31 AM.
Tags
None
Referenced Files
F13301148: D15361.diff
Fri, Jun 7, 3:28 PM
F13293291: D15361.id37039.diff
Wed, Jun 5, 7:15 AM
F13293290: D15361.id37038.diff
Wed, Jun 5, 7:15 AM
F13293289: D15361.id.diff
Wed, Jun 5, 7:15 AM
F13293288: D15361.diff
Wed, Jun 5, 7:15 AM
F13246432: D15361.id37038.diff
Thu, May 23, 10:18 AM
F13208142: D15361.id37038.diff
Thu, May 16, 9:49 AM
F13197283: D15361.id.diff
Mon, May 13, 12:00 AM
Subscribers
None

Details

Summary

Fixes T10466. Currently, clicking "Disable Mail" or "Enable Mail" on a project toggles an edge, but it gets a default "added an edge" story and transaction record.

These are confusing, useless and not interesting, so just hide them.

Test Plan
  • Before patch: clicked enable/disable mail, saw "added an edge" / "removed an edge" stories in feed and project history.
  • After patch: clicked enable/disable mail, saw nothing in feed or project history.
  • (Note that this patch is not retroactive for feed, so already-published stories won't unpublish.)

Diff Detail

Repository
rP Phabricator
Branch
nomaildisable
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10878
Build 13415: Run Core Tests
Build 13414: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Don't publish anything for "Disable Mail" / "Enable Mail" on projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 29 2016, 12:32 AM
This revision was automatically updated to reflect the committed changes.