Page MenuHomePhabricator
Differential D15357

Use EditEngine for Harbormaster Build Plans, fix some crumbs/mobile stuff
ClosedPublic
Actions

Authored by epriestley on Feb 27 2016, 3:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 4:53 AM
Unknown Object (File)
Wed, Dec 18, 1:12 AM
Unknown Object (File)
Wed, Dec 11, 2:58 AM
Unknown Object (File)
Wed, Dec 4, 11:58 AM
Unknown Object (File)
Tue, Nov 26, 1:17 PM
Unknown Object (File)
Mon, Nov 25, 6:42 AM
Unknown Object (File)
Nov 21 2024, 9:35 AM
Unknown Object (File)
Nov 16 2024, 6:53 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10457: Improve Harbomaster/Drydock UI/UX before release
Commits
Restricted Diffusion Commit
rP5295c6ba1e61: Use EditEngine for Harbormaster Build Plans, fix some crumbs/mobile stuff
Summary

Ref T10457.

  • Use EditEngine for Build Plans.
  • Fix some minor issues with crumbs being inconsistent.
  • Fix some minor issues with mobile menus not being consistent/available.
Test Plan
  • Created and edited build plans.
  • Poked around in mobile width, verified mobile menu had the right stuff in it.

Diff Detail

Repository
rP Phabricator
Branch
dry6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10866
Build 13399: Run Core Tests
Build 13398: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37029.Feb 27 2016, 3:54 AM
epriestley retitled this revision from to Use EditEngine for Harbormaster Build Plans, fix some crumbs/mobile stuff.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10457: Improve Harbomaster/Drydock UI/UX before release.
chad accepted this revision.Feb 27 2016, 4:14 AM
chad edited edge metadata.

image.gif (375×500 px, 510 KB)

This revision is now accepted and ready to land.Feb 27 2016, 4:14 AM
Closed by commit rP5295c6ba1e61: Use EditEngine for Harbormaster Build Plans, fix some crumbs/mobile stuff (authored by epriestley, committed by epriestley). · Explain WhyFeb 27 2016, 3:13 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D19746: Make the Harbormaster build plan edit engine forms configurable.Oct 16 2018, 7:48 PM

Revision Contents
Changeset List

Diff 37029

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/harbormaster/application/PhabricatorHarbormasterApplication.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterBuildableListController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanEditController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanListController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterPlanRunController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterStepAddController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterStepDeleteController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterStepEditController.php

Loading...
View Options

src/applications/harbormaster/controller/HarbormasterStepViewController.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildPlanEditEngine.php

Loading...
View Options

src/applications/harbormaster/editor/HarbormasterBuildPlanEditor.php

Loading...
Phabricator · Built by Phacility