Differential D15331

Remove dark Phabricator special CSS
ClosedPublic
Actions

Authored by chad on Feb 23 2016, 4:38 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T10424: Background colors (vs gradients) do not work on Workboards if "Dark" theme is set

Commits

Restricted Diffusion Commit
rP800d800766a1: Remove dark Phabricator special CSS

Summary

Looks like the border was almost always overridden and the background was only slightly darker. Safe to remove these. Fixes T10424

Test Plan

Set Workboard to "red" see red workboard. Toggle CSS on and off on homepage, note little to no visual difference.

Diff Detail

Repository

rP Phabricator

Branch

wkbrd-clrs (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10816
Build 13326: Run Core Tests
Build 13325: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36976.Feb 23 2016, 4:38 PM

chad retitled this revision from to Remove dark Phabricator special CSS.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T10424: Background colors (vs gradients) do not work on Workboards if "Dark" theme is set.

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 23 2016, 4:38 PM

epriestley accepted this revision.Feb 23 2016, 4:38 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 23 2016, 4:38 PM

Closed by commit rP800d800766a1: Remove dark Phabricator special CSS (authored by chad, committed by chad). · Explain WhyFeb 23 2016, 4:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

4 lines

webroot/

rsrc/

css/

application/

base/

phui-theme.css

14 lines

Diff 36976

View Options

resources/celerity/map.php