Page MenuHomePhabricator

Background colors (vs gradients) do not work on Workboards if "Dark" theme is set
Closed, ResolvedPublic

Description

To reproduce:

  • Choose a Workboard, select Change Background, pick a color (like "Blue") not a gradient.
  • View workboard.

Expected behavior:

  • Background is blue.

Actual behavior:

  • Background is still grey, although frame has adjusted to white text, as though color was present.

I think this is because phui-theme-dark and phui-workboard-($color) have the same strength and fight:

plain-color.png (1×2 px, 448 KB)

If this is a pain to fix, one junk workaround I could imagine is to use linear-gradient to give the flat colors a "gradient" background image from, say, blue to the exact same blue.

Event Timeline

epriestley renamed this task from Colors (vs gradients) do not work on Workboards to Background colors (vs gradients) do not work on Workboards.Feb 23 2016, 1:03 PM
epriestley created this task.
epriestley added a subscriber: chad.

Oh, is this just a dark-theme issue? That seems easy to fix.

Oh, I do have that set locally -- I thought phui-theme-dark was just the default (since we got rid of light?) but this fixes itself if I switch to, e.g., the red header.

(The difference between the dark and default background colors is so subtle on my monitor that I never noticed it.)

epriestley renamed this task from Background colors (vs gradients) do not work on Workboards to Background colors (vs gradients) do not work on Workboards if "Dark" theme is set.Feb 23 2016, 3:59 PM

In conclusion, we should never add options to the product.