Page MenuHomePhabricator

Save, then restore scroll position in Chrome textareas on remarkup assist
ClosedPublic

Authored by epriestley on Feb 19 2016, 10:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 3:30 PM
Unknown Object (File)
Tue, Dec 3, 5:32 PM
Unknown Object (File)
Tue, Dec 3, 5:32 PM
Unknown Object (File)
Tue, Dec 3, 5:26 PM
Unknown Object (File)
Tue, Dec 3, 5:07 PM
Unknown Object (File)
Sun, Nov 24, 3:12 PM
Unknown Object (File)
Nov 20 2024, 5:45 AM
Unknown Object (File)
Nov 19 2024, 6:03 PM
Subscribers
None

Details

Summary

Fixes T10396. Seems like this has been around for a while (references from 2011):

http://stackoverflow.com/questions/4002312/chrome-resets-the-textarea-scroll-bar-scrolltop-when-focus-is-called
https://bugs.chromium.org/p/chromium/issues/detail?id=75072

Commenting out this focus() seemed to fix the issue locally, at the cost of not focusing.

Saving, focusing, then restoring seems to produce the correct behavior everywhere.

Test Plan
  • In Safari, Firefox and Chrome, typed a ton of text into a remarkup area (more than the height of the area, so it has a scrollbar).
  • Selected some text near the top.
  • Clicked "B" to bold the text.
  • Scroll position remained the same in all browsers (previously: in Chrome, it changed).

Diff Detail

Repository
rP Phabricator
Branch
chromefocus
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10779
Build 13271: Run Core Tests
Build 13270: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Save, then restore scroll position in Chrome textareas on remarkup assist.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 19 2016, 10:53 PM
This revision was automatically updated to reflect the committed changes.