Page MenuHomePhabricator

Make callsigns editable on repository basic information
ClosedPublic

Authored by epriestley on Feb 18 2016, 1:57 PM.
Tags
None
Referenced Files
F13151606: D15304.diff
Sat, May 4, 6:42 PM
Unknown Object (File)
Tue, Apr 30, 11:57 PM
Unknown Object (File)
Sat, Apr 20, 2:53 AM
Unknown Object (File)
Fri, Apr 19, 4:12 PM
Unknown Object (File)
Thu, Apr 11, 8:20 AM
Unknown Object (File)
Thu, Apr 11, 8:09 AM
Unknown Object (File)
Thu, Apr 11, 7:57 AM
Unknown Object (File)
Apr 2 2024, 6:36 PM
Subscribers
None

Details

Summary

Ref T4245. This is a prelude to removing them from the "create" screen.

Currently, if you try to delete the callsign you get an unceremonious database error, but the next diff (or maybe two) will permit that, so I didn't put any "this is required yada yada" text in.

This could also maybe use some big flashing warning lights and a "if you edit this, all your URIs break" but I'll save that for later.

Test Plan

Changed the callsign for a repository.

Diff Detail

Repository
rP Phabricator
Branch
call10
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10756
Build 13240: Run Core Tests
Build 13239: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Make callsigns editable on repository basic information.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
src/applications/repository/editor/PhabricatorRepositoryEditor.php
471

lul

src/applications/repository/storage/PhabricatorRepository.php
320

wut

327

haha

This revision is now accepted and ready to land.Feb 18 2016, 4:18 PM

yeah I was like "wtf?" and then I was like "oh.. wtf?"

This revision was automatically updated to reflect the committed changes.