Page MenuHomePhabricator
Differential D15287

Show coverage bars with aggregate coverage in repositories with coverage information available
AcceptedPublic
Actions

Authored by epriestley on Feb 17 2016, 2:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 9:34 AM
Unknown Object (File)
Mon, Dec 16, 6:13 AM
Unknown Object (File)
Mon, Dec 9, 4:14 PM
Unknown Object (File)
Thu, Dec 5, 3:39 PM
Unknown Object (File)
Tue, Dec 3, 2:31 AM
Unknown Object (File)
Tue, Dec 3, 2:31 AM
Unknown Object (File)
Wed, Nov 27, 2:12 PM
Unknown Object (File)
Mon, Nov 25, 2:42 PM
View All Files
Subscribers
None
Tokens
"Cup of Joe" token, awarded by yelirekim.

Details

Reviewers
yelirekim
chad
Maniphest Tasks
T9524: Show aggregate subdirectory coverage in Diffusion browse views
Summary

Ref T9524. This adds UI for the new aggregate data, largely based on D14803 but with SegmentBars.

Test Plan

Screen Shot 2016-02-16 at 6.50.22 PM.png (563×970 px, 148 KB)

Diff Detail

Repository
rP Phabricator
Branch
coverage2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10726
Build 13190: Run Core Tests
Build 13189: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36882.Feb 17 2016, 2:53 AM
epriestley retitled this revision from to Show coverage bars with aggregate coverage in repositories with coverage information available.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, yelirekim.
epriestley added a task: T9524: Show aggregate subdirectory coverage in Diffusion browse views.
Herald edited edge metadata. · View Herald TranscriptFeb 17 2016, 2:53 AM
epriestley added a comment.Feb 17 2016, 2:58 AM

One thing this doesn't do (that D14803 did, sort of implicitly) is colorize the bars, but I'm hesitant to start mandating what counts as red vs green coverage in the upstream.

epriestley updated this object.Feb 17 2016, 3:11 AM
epriestley edited edge metadata.
epriestley mentioned this in Q314: Why does coverage information include the "branch"? (Answer 330).Feb 17 2016, 3:17 AM
chad accepted this revision.Feb 17 2016, 3:23 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 17 2016, 3:23 AM
epriestley mentioned this in T9524: Show aggregate subdirectory coverage in Diffusion browse views.Feb 17 2016, 9:35 PM
epriestley mentioned this in D16322: Render lines added, removed in Revision.Jul 22 2016, 11:16 PM
yelirekim awarded a token.Jul 24 2016, 4:05 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
resources/
celerity/
4 lines100%
Loading...
src/
applications/
diffusion/
controller/
122 lines1%
Loading...
view/
15 lines1%
Loading...
webroot/
rsrc/
css/
phui/
4 lines--

Diff 36882

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionLastModifiedController.php

Loading...
View Options

src/applications/diffusion/view/DiffusionBrowseTableView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-segment-bar-view.css

Loading...
Phabricator · Built by Phacility