Page MenuHomePhabricator

Give Owners real view and edit policies
ClosedPublic

Authored by epriestley on Feb 15 2016, 7:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 5, 3:26 PM
Unknown Object (File)
Tue, Mar 5, 11:42 AM
Unknown Object (File)
Tue, Mar 5, 11:42 AM
Unknown Object (File)
Tue, Mar 5, 11:42 AM
Unknown Object (File)
Tue, Mar 5, 9:19 AM
Unknown Object (File)
Feb 14 2024, 11:11 AM
Unknown Object (File)
Feb 14 2024, 11:10 AM
Unknown Object (File)
Feb 14 2024, 11:10 AM
Subscribers
None
Tokens
"Baby Tequila" token, awarded by yelirekim.

Details

Summary

Fixes T10360. In modern code, most of the meat is automatic.

Test Plan
  • Edited view policy and edit policy from web UI.
  • Viewed package, saw policy badge in header.
  • Tried to edit a package as a user without permission, got appropriate disabled states and errors.
  • Changed policies via Conduit.
  • Tried to view a package as a user without permission.

Diff Detail

Repository
rP Phabricator
Branch
owners1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10698
Build 13147: Run Core Tests
Build 13146: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Give Owners real view and edit policies.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 15 2016, 7:55 PM
This revision was automatically updated to reflect the committed changes.