Page MenuHomePhabricator

Don't try to import proxy columns
ClosedPublic

Authored by epriestley on Feb 12 2016, 9:57 PM.
Tags
None
Referenced Files
F14044402: D15265.id36834.diff
Tue, Nov 12, 4:00 PM
F14019164: D15265.diff
Tue, Nov 5, 9:40 PM
F14019118: D15265.id.diff
Tue, Nov 5, 9:34 PM
F13991950: D15265.diff
Tue, Oct 22, 1:30 PM
F13973599: D15265.diff
Fri, Oct 18, 1:38 AM
F13957826: D15265.id36834.diff
Mon, Oct 14, 11:31 AM
Unknown Object (File)
Sep 5 2024, 6:31 PM
Unknown Object (File)
Sep 5 2024, 6:31 PM
Subscribers
None

Details

Summary

Fixes T10346. You finally wrung a clue out of the reporter and I think I figured this out.

Here's the bug:

  • Create a project with a workboard and subprojects/milestones.
  • Create a new project, import columns from the first project.
  • We incorrectly import empty columns for the subprojects/milestons.

Instead, skip proxy columns during import.

Also, allow "hide column" to continue on missing fields, so columns with no name can be hidden.

Test Plan
  • Did the stuff above.
  • Workboard no longer populated with a bunch of "Unnamed Column" columns.
  • Hid several "Unnamed Column" columns.

Diff Detail

Repository
rP Phabricator
Branch
iproxy
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10676
Build 13114: Run Core Tests
Build 13113: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Don't try to import proxy columns.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 12 2016, 9:59 PM
This revision was automatically updated to reflect the committed changes.