Page MenuHomePhabricator

Allow workboard sorting and filtering to be saved as defaults
ClosedPublic

Authored by epriestley on Feb 12 2016, 2:42 PM.
Tags
None
Referenced Files
F14037114: D15260.id36821.diff
Sun, Nov 10, 1:54 PM
F14015961: D15260.id36821.diff
Mon, Nov 4, 3:27 AM
F14010812: D15260.id36820.diff
Thu, Oct 31, 12:36 PM
F14004689: D15260.id36820.diff
Sun, Oct 27, 1:13 AM
F14001015: D15260.id36821.diff
Fri, Oct 25, 3:18 AM
F13999750: D15260.diff
Thu, Oct 24, 4:59 PM
F13992476: D15260.id.diff
Tue, Oct 22, 4:56 PM
Unknown Object (File)
Oct 10 2024, 10:40 PM
Subscribers
None

Details

Summary

Fixes T6641. This allows users who have permission to edit a project to use "Save as Default" to save the current order and filter as defaults for the project.

These are per-board defaults, and apply to all users. The rationale is that I think the best default ordering/filtering depends mostly on the board, not the viewer.

This seems to align with most requests in the task, although rationale is a bit light. But, for example, it seems reasonable you might want to change the default filter to "All Tasks" on a sprint board, so you can see what's in the "Done" column.

This also fixes some minor issues I ran into:

  • Herald could hit an issue while checking permissions if the project was a subproject and a non-member had a triggering rule.
  • "Advanced filter..." did not prefill with the current filter.
Test Plan
  • Set default order and filter on a workboard.
  • Reloaded board, saw settings stick.
  • Tried to edit a board as an unprivileged user (disabled menu items, error).
  • Reviewed transaction log.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Allow workboard sorting and filtering to be saved as defaults.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

Screen Shot 2016-02-12 at 6.19.46 AM.png (219×295 px, 19 KB)

Screen Shot 2016-02-12 at 6.19.50 AM.png (233×592 px, 27 KB)

My use of fa-floppy-o might be a little too far.

chad edited edge metadata.
This revision is now accepted and ready to land.Feb 12 2016, 3:32 PM
This revision was automatically updated to reflect the committed changes.