Paths

Table of Contentst

Differential D15245

Don't link commit uri in Crumbs
ClosedPublic
Actions

Authored by chad on Feb 11 2016, 6:48 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T7628: Diffusion commit pages should mention plain commit hash somewhere

Commits

Restricted Diffusion Commit
rPf163d83935d9: Don't link commit uri in Crumbs

Summary

These are not needed I think? and handy for cut and paste. Fixes T7628

Test Plan

cut and paste easier from commit hash.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 36793.Feb 11 2016, 6:48 PM

chad retitled this revision from to Don't link commit uri in Crumbs.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 11 2016, 6:48 PM

One inline. You can also mark this as fixing T7628, probably.

src/applications/diffusion/controller/DiffusionController.php
150	This can be `formatCommitName($stable_commit, $local = true)` to drop the `rX` prefix in most cases. It's unambiguous in these UIs.

This revision is now accepted and ready to land.Feb 11 2016, 6:51 PM

That is, adding $local = true should change it from showing rXabcdef to abcdef in Git and Mercurial.

You can still grab the full-context hash out of the URI so I think that's fine, even if we have some users who like copy-pasting full-context URIs.

chad updated this object.Feb 11 2016, 7:21 PM

chad edited edge metadata.

chad added a task: T7628: Diffusion commit pages should mention plain commit hash somewhere.

Closed by commit rPf163d83935d9: Don't link commit uri in Crumbs (authored by chad, committed by chad). · Explain WhyFeb 11 2016, 7:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionController.php

5 lines

Diff 36794

View Options

src/applications/diffusion/controller/DiffusionController.php

Don't link commit uri in CrumbsClosedPublicActions