Page MenuHomePhabricator
Differential D15245

Don't link commit uri in Crumbs
ClosedPublic
Actions

Authored by chad on Feb 11 2016, 6:48 PM.
Tags
None
Referenced Files
F15491373: D15245.diff
Sat, Apr 12, 2:36 AM
F15455617: D15245.diff
Sun, Mar 30, 3:38 AM
F15451057: D15245.id.diff
Fri, Mar 28, 7:53 PM
F15435226: D15245.id36794.diff
Tue, Mar 25, 7:27 AM
F15434158: D15245.id36794.diff
Tue, Mar 25, 2:19 AM
F15394576: D15245.id.diff
Sat, Mar 15, 11:56 PM
F15384886: D15245.id36793.diff
Fri, Mar 14, 9:05 PM
F15375012: D15245.id36793.diff
Mar 12 2025, 9:11 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7628: Diffusion commit pages should mention plain commit hash somewhere
Commits
Restricted Diffusion Commit
rPf163d83935d9: Don't link commit uri in Crumbs
Summary

These are not needed I think? and handy for cut and paste. Fixes T7628

Test Plan

cut and paste easier from commit hash.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 36793.Feb 11 2016, 6:48 PM
chad retitled this revision from to Don't link commit uri in Crumbs.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptFeb 11 2016, 6:48 PM
epriestley accepted this revision.Feb 11 2016, 6:51 PM
epriestley edited edge metadata.

One inline. You can also mark this as fixing T7628, probably.

src/applications/diffusion/controller/DiffusionController.php
150

This can be formatCommitName($stable_commit, $local = true) to drop the rX prefix in most cases. It's unambiguous in these UIs.

This revision is now accepted and ready to land.Feb 11 2016, 6:51 PM
epriestley added a comment.Feb 11 2016, 6:52 PM

That is, adding $local = true should change it from showing rXabcdef to abcdef in Git and Mercurial.

You can still grab the full-context hash out of the URI so I think that's fine, even if we have some users who like copy-pasting full-context URIs.

chad updated this object.Feb 11 2016, 7:21 PM
chad edited edge metadata.
chad added a task: T7628: Diffusion commit pages should mention plain commit hash somewhere.
Closed by commit rPf163d83935d9: Don't link commit uri in Crumbs (authored by chad, committed by chad). · Explain WhyFeb 11 2016, 7:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
5 lines

Diff 36794

View Options

src/applications/diffusion/controller/DiffusionController.php

Loading...
Phabricator · Built by Phacility