Differential D15226

Mostly move workboard card moves to new Workboard code
ClosedPublic
Actions

Authored by epriestley on Feb 9 2016, 1:37 PM.

Tags

None

Referenced Files

	F13103234: D15226.diff
	Sat, Apr 27, 9:55 AM

	F13099430: D15226.diff
	Fri, Apr 26, 3:16 PM

	Unknown Object (File)
	Mon, Apr 22, 6:45 AM

	Unknown Object (File)
	Sun, Apr 14, 10:49 PM

	Unknown Object (File)
	Thu, Apr 11, 3:44 AM

	Unknown Object (File)
	Thu, Apr 11, 3:44 AM

	Unknown Object (File)
	Thu, Apr 11, 3:44 AM

	Unknown Object (File)
	Wed, Apr 10, 6:16 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T4900: Workboards updating in real time

Commits

Restricted Diffusion Commit
rPbc591b1b5f7d: Mostly move workboard card moves to new Workboard code

Summary

Ref T4900. This gets moves on the new stuff and cleans them up a little.

Two behaviors haven't been ported yet: height adjustment during drags (which is broken anyway with inner scroll) and updating point counts (coming soon).

Test Plan

Dragged cards around on a board, including top/bottom positions and normal/priority sort.

Diff Detail

Repository

Branch

board14

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10590
Build 12987: Run Core Tests
Build 12986: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	179 ms	PhabricatorCelerityTestCase::Unknown Unit Message ("")
	0 ms	AlmanacNamesTestCase::Unknown Unit Message ("")
	0 ms	AlmanacServiceTypeTestCase::Unknown Unit Message ("")
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("")
	0 ms	AphrontHTTPSinkTestCase::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 308 Passed)

Event Timeline

epriestley updated this revision to Diff 36749.Feb 9 2016, 1:37 PM

epriestley retitled this revision from to Mostly move workboard card moves to new Workboard code.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T4900: Workboards updating in real time.

chad accepted this revision.Feb 9 2016, 2:38 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 9 2016, 2:38 PM

Closed by commit rPbc591b1b5f7d: Mostly move workboard card moves to new Workboard code (authored by epriestley, committed by epriestley). · Explain WhyFeb 10 2016, 9:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

50 lines

webroot/

rsrc/

js/

application/

projects/

85 lines

behavior-project-boards.js

95 lines

Diff 36749

resources/celerity/map.php

Loading...

webroot/rsrc/js/application/projects/Workboard.js

Loading...

webroot/rsrc/js/application/projects/behavior-project-boards.js

Loading...