Paths

Table of Contentst

Differential D15206

Fix an issue with viewing an empty board with milestone columns
ClosedPublic
Actions

Authored by epriestley on Feb 7 2016, 5:21 AM.

Tags

None

Referenced Files

	F13088927: D15206.diff
	Thu, Apr 25, 1:36 AM

	Unknown Object (File)
	Tue, Apr 23, 11:43 PM

	Unknown Object (File)
	Tue, Apr 16, 8:38 PM

	Unknown Object (File)
	Fri, Apr 12, 12:32 AM

	Unknown Object (File)
	Thu, Apr 11, 9:16 AM

	Unknown Object (File)
	Sun, Mar 31, 8:01 PM

	Unknown Object (File)
	Sun, Mar 31, 4:20 PM

	Unknown Object (File)
	Mar 24 2024, 8:06 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10010: Implement Subprojects

Commits

Restricted Diffusion Commit
rPd9bd062bba72: Fix an issue with viewing an empty board with milestone columns

Summary

Viewing an empty board with milestone columns did a meaningless edge query. Don't do that.
When creating the first milestone of a parent, force the indexing engine to rematerialize it inline. This sets hasMilestones properly. Otherwise, the daemons may take some time to fix this in the indexer.

Test Plan

Viewed an empty board of a project with a milestone.
Viewed a normal board.
Created the first milestone of a project with a big queue of daemons, saw project state immediately fully reflect the project having milestones.

Diff Detail

Repository

Branch

board1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10549
Build 12925: Run Core Tests
Build 12924: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36708.Feb 7 2016, 5:21 AM

epriestley retitled this revision from to Fix an issue with viewing an empty board with milestone columns.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10010: Implement Subprojects.

chad accepted this revision.Feb 7 2016, 5:37 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 7 2016, 5:37 AM

Closed by commit rPd9bd062bba72: Fix an issue with viewing an empty board with milestone columns (authored by epriestley, committed by epriestley). · Explain WhyFeb 7 2016, 10:36 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

editor/

PhabricatorProjectTransactionEditor.php

6 lines

engine/

PhabricatorBoardLayoutEngine.php

2 lines

Diff 36708

src/applications/project/editor/PhabricatorProjectTransactionEditor.php

Loading...

src/applications/project/engine/PhabricatorBoardLayoutEngine.php

Loading...