Page MenuHomePhabricator

Fix an issue with viewing an empty board with milestone columns
ClosedPublic

Authored by epriestley on Feb 7 2016, 5:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 17, 6:25 AM
Unknown Object (File)
Wed, Nov 16, 3:55 PM
Unknown Object (File)
Wed, Nov 16, 3:55 PM
Unknown Object (File)
Wed, Nov 16, 6:40 AM
Unknown Object (File)
Sat, Nov 12, 6:19 AM
Unknown Object (File)
Thu, Nov 10, 4:56 AM
Unknown Object (File)
Thu, Nov 10, 4:56 AM
Unknown Object (File)
Thu, Nov 10, 4:56 AM
Subscribers
None

Details

Summary

Ref T10010.

  • Viewing an empty board with milestone columns did a meaningless edge query. Don't do that.
  • When creating the first milestone of a parent, force the indexing engine to rematerialize it inline. This sets hasMilestones properly. Otherwise, the daemons may take some time to fix this in the indexer.
Test Plan
  • Viewed an empty board of a project with a milestone.
  • Viewed a normal board.
  • Created the first milestone of a project with a big queue of daemons, saw project state immediately fully reflect the project having milestones.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix an issue with viewing an empty board with milestone columns.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 7 2016, 5:37 AM
This revision was automatically updated to reflect the committed changes.