Page MenuHomePhabricator
Differential D15189

Fix dead column link and provide more milestone UI context
ClosedPublic
Actions

Authored by epriestley on Feb 5 2016, 8:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 12:55 AM
Unknown Object (File)
Mon, Apr 8, 1:09 PM
Unknown Object (File)
Sun, Apr 7, 3:10 PM
Unknown Object (File)
Sat, Apr 6, 10:19 PM
Unknown Object (File)
Fri, Apr 5, 5:58 PM
Unknown Object (File)
Apr 2 2024, 9:19 PM
Unknown Object (File)
Mar 16 2024, 12:24 PM
Unknown Object (File)
Mar 9 2024, 7:13 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10286: Design a Milestone Tag
T10287: Clicking on a Milestone's workboard link 404's
Commits
Restricted Diffusion Commit
rP5092bcf533a5: Fix dead column link and provide more milestone UI context
Summary

Fixes T10287. Ref T10286.

  • Link stuff properly.
  • Generally, show "Parent (Milestone)" instead of "Milestone".
  • This probably doesn't get 100% of getName() -> getDisplayName() swaps, but we can get those as we catch them.
Test Plan

See T10286. Also clicked stuff.

Diff Detail

Repository
rP Phabricator
Branch
mile1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10509
Build 12864: Run Core Tests
Build 12863: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36669.Feb 5 2016, 8:25 PM
epriestley retitled this revision from to Fix dead column link and provide more milestone UI context.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T10287: Clicking on a Milestone's workboard link 404's, T10286: Design a Milestone Tag.
chad accepted this revision.Feb 5 2016, 8:25 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 5 2016, 8:25 PM
Closed by commit rP5092bcf533a5: Fix dead column link and provide more milestone UI context (authored by epriestley, committed by epriestley). · Explain WhyFeb 5 2016, 8:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36669

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectManageController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectMembersViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
View Options

src/applications/project/events/PhabricatorProjectUIEventListener.php

Loading...
View Options

src/applications/project/phid/PhabricatorProjectProjectPHIDType.php

Loading...
View Options

src/applications/project/storage/PhabricatorProject.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectDatasource.php

Loading...
Phabricator · Built by Phacility