Page MenuHomePhabricator
Differential D15189

Fix dead column link and provide more milestone UI context
ClosedPublic
Actions

Authored by epriestley on Feb 5 2016, 8:25 PM.
Tags
None
Referenced Files
F14056228: D15189.diff
Sat, Nov 16, 7:02 PM
F14039907: D15189.id36669.diff
Mon, Nov 11, 6:40 AM
F14018059: D15189.id36669.diff
Tue, Nov 5, 3:46 AM
F14014659: D15189.id36670.diff
Sun, Nov 3, 6:34 AM
F14011277: D15189.id36669.diff
Thu, Oct 31, 10:28 PM
F14010302: D15189.id36669.diff
Thu, Oct 31, 6:58 AM
F14002038: D15189.id36670.diff
Fri, Oct 25, 2:30 PM
F13999908: D15189.id36669.diff
Thu, Oct 24, 5:58 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10286: Design a Milestone Tag
T10287: Clicking on a Milestone's workboard link 404's
Commits
Restricted Diffusion Commit
rP5092bcf533a5: Fix dead column link and provide more milestone UI context
Summary

Fixes T10287. Ref T10286.

  • Link stuff properly.
  • Generally, show "Parent (Milestone)" instead of "Milestone".
  • This probably doesn't get 100% of getName() -> getDisplayName() swaps, but we can get those as we catch them.
Test Plan

See T10286. Also clicked stuff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36669.Feb 5 2016, 8:25 PM
epriestley retitled this revision from to Fix dead column link and provide more milestone UI context.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added tasks: T10287: Clicking on a Milestone's workboard link 404's, T10286: Design a Milestone Tag.
chad accepted this revision.Feb 5 2016, 8:25 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 5 2016, 8:25 PM
Closed by commit rP5092bcf533a5: Fix dead column link and provide more milestone UI context (authored by epriestley, committed by epriestley). · Explain WhyFeb 5 2016, 8:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36670

View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectManageController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectMembersViewController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
View Options

src/applications/project/events/PhabricatorProjectUIEventListener.php

Loading...
View Options

src/applications/project/phid/PhabricatorProjectProjectPHIDType.php

Loading...
View Options

src/applications/project/storage/PhabricatorProject.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectDatasource.php

Loading...
Phabricator · Built by Phacility