Fix bad rendering pathway on user profiles for viewers without Badges application
ClosedPublic
Actions

Authored by epriestley on Feb 4 2016, 3:15 PM.

Details

Reviewers

chad

Maniphest Tasks

T10275: People profile display error when prototypes are disabled

Commits

Restricted Diffusion Commit
rP42954bc5ac81: Fix bad rendering pathway on user profiles for viewers without Badges…

Summary

Fixes T10275. We'd fatal on $flex not being defined.

Test Plan

Uninstalled badges, viewed profile. Before: fatal; now: no badges element appears but profile renders properly.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36652.Feb 4 2016, 3:15 PM

epriestley retitled this revision from to Fix bad rendering pathway on user profiles for viewers without Badges application.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10275: People profile display error when prototypes are disabled.

thx

This revision is now accepted and ready to land.Feb 4 2016, 3:17 PM

Closed by commit rP42954bc5ac81: Fix bad rendering pathway on user profiles for viewers without Badges… (authored by epriestley, committed by epriestley). · Explain WhyFeb 4 2016, 3:17 PM

This revision was automatically updated to reflect the committed changes.

npz :3

Revision Contents
Changeset List

Path

Size

src/

applications/

people/

controller/

PhabricatorPeopleProfileViewController.php

57 lines

Diff 36653

View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Fix bad rendering pathway on user profiles for viewers without Badges applicationClosedPublicActions