Page MenuHomePhabricator

Fix bad rendering pathway on user profiles for viewers without Badges application
ClosedPublic

Authored by epriestley on Feb 4 2016, 3:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 23, 11:17 PM
Unknown Object (File)
Sat, Mar 9, 3:17 PM
Unknown Object (File)
Tue, Mar 5, 9:19 AM
Unknown Object (File)
Feb 16 2024, 1:14 AM
Unknown Object (File)
Feb 7 2024, 4:35 AM
Unknown Object (File)
Jan 27 2024, 8:14 PM
Unknown Object (File)
Jan 23 2024, 11:09 AM
Unknown Object (File)
Jan 22 2024, 4:31 PM
Subscribers
None

Details

Summary

Fixes T10275. We'd fatal on $flex not being defined.

Test Plan

Uninstalled badges, viewed profile. Before: fatal; now: no badges element appears but profile renders properly.

Diff Detail

Repository
rP Phabricator
Branch
pprofile
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10492
Build 12837: Run Core Tests
Build 12836: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Fix bad rendering pathway on user profiles for viewers without Badges application.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

thx

This revision is now accepted and ready to land.Feb 4 2016, 3:17 PM
This revision was automatically updated to reflect the committed changes.