Page MenuHomePhabricator
Differential D15182

Fix bad rendering pathway on user profiles for viewers without Badges application
ClosedPublic
Actions

Authored by epriestley on Feb 4 2016, 3:15 PM.
Tags
None
Referenced Files
F15461870: D15182.id.diff
Tue, Apr 1, 12:02 PM
F15460941: D15182.id36653.diff
Tue, Apr 1, 3:33 AM
F15459015: D15182.id.diff
Mon, Mar 31, 9:08 AM
F15458934: D15182.id36652.diff
Mon, Mar 31, 8:26 AM
F15456187: D15182.diff
Sun, Mar 30, 7:42 AM
F15432072: D15182.id36653.diff
Mon, Mar 24, 3:59 PM
F15429316: D15182.id36653.diff
Mon, Mar 24, 1:37 AM
F15414174: D15182.diff
Wed, Mar 19, 11:17 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10275: People profile display error when prototypes are disabled
Commits
Restricted Diffusion Commit
rP42954bc5ac81: Fix bad rendering pathway on user profiles for viewers without Badges…
Summary

Fixes T10275. We'd fatal on $flex not being defined.

Test Plan

Uninstalled badges, viewed profile. Before: fatal; now: no badges element appears but profile renders properly.

Diff Detail

Repository
rP Phabricator
Branch
pprofile
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10492
Build 12837: Run Core Tests
Build 12836: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36652.Feb 4 2016, 3:15 PM
epriestley retitled this revision from to Fix bad rendering pathway on user profiles for viewers without Badges application.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10275: People profile display error when prototypes are disabled.
chad accepted this revision.Feb 4 2016, 3:17 PM
chad edited edge metadata.

thx

This revision is now accepted and ready to land.Feb 4 2016, 3:17 PM
Closed by commit rP42954bc5ac81: Fix bad rendering pathway on user profiles for viewers without Badges… (authored by epriestley, committed by epriestley). · Explain WhyFeb 4 2016, 3:17 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Feb 4 2016, 3:17 PM

npz :3

Revision Contents
Changeset List

PathSize
src/
applications/
people/
controller/
57 lines

Diff 36652

View Options

src/applications/people/controller/PhabricatorPeopleProfileViewController.php

Loading...
Phabricator · Built by Phacility