Page MenuHomePhabricator
Differential D15131

Show blame colors on all lines, instead of only the first affected line
ClosedPublic
Actions

Authored by epriestley on Jan 28 2016, 7:10 PM.
Tags
None
Referenced Files
F14057573: D15131.diff
Sun, Nov 17, 4:44 AM
F14055845: D15131.id.diff
Sat, Nov 16, 4:15 PM
F14044951: D15131.id36533.diff
Tue, Nov 12, 11:18 PM
F14034401: D15131.id36533.diff
Sun, Nov 10, 12:00 AM
F14009722: D15131.id36534.diff
Wed, Oct 30, 11:08 PM
F14009721: D15131.id36533.diff
Wed, Oct 30, 11:08 PM
F14009720: D15131.id.diff
Wed, Oct 30, 11:08 PM
F14008328: D15131.diff
Tue, Oct 29, 7:37 PM
View All Files
Subscribers
None

Details

Reviewers
avivey
chad
Maniphest Tasks
T10226: diffusion blame: Only first line number is highlighted
Commits
Restricted Diffusion Commit
rPa5f62235537d: Show blame colors on all lines, instead of only the first affected line
Summary

Fixes T10226. I just made a mistake here when rewriting this recently.

Test Plan

Screen Shot 2016-01-28 at 11.09.53 AM.png (1×1 px, 287 KB)

Diff Detail

Repository
rP Phabricator
Branch
bcolor1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10372
Build 12653: Run Core Tests
Build 12652: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36533.Jan 28 2016, 7:10 PM
epriestley retitled this revision from to Show blame colors on all lines, instead of only the first affected line.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10226: diffusion blame: Only first line number is highlighted.
avivey accepted this revision.Jan 28 2016, 7:17 PM
avivey added a reviewer: avivey.
This revision is now accepted and ready to land.Jan 28 2016, 7:17 PM
Closed by commit rPa5f62235537d: Show blame colors on all lines, instead of only the first affected line (authored by epriestley, committed by epriestley). · Explain WhyJan 28 2016, 7:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
6 lines

Diff 36533

View Options

src/applications/diffusion/controller/DiffusionBrowseController.php

Loading...
Phabricator · Built by Phacility