Page MenuHomePhabricator
Differential D15129

Move FontIcon calls to Icon
ClosedPublic
Actions

Authored by chad on Jan 28 2016, 4:43 PM.
Tags
None
Referenced Files
F15555232: D15129.id36529.diff
Mon, Apr 28, 10:29 AM
F15543974: D15129.id36528.largetrue.diff
Sat, Apr 26, 2:01 AM
F15537609: D15129.id36529.largetrue.diff
Thu, Apr 24, 2:44 PM
F15533605: D15129.id36528.diff
Wed, Apr 23, 8:46 PM
F15520258: D15129.id36529.diff
Sun, Apr 20, 5:02 AM
F15492504: D15129.id36528.diff
Sat, Apr 12, 3:09 PM
F15485683: D15129.diff
Thu, Apr 10, 1:44 AM
F15484094: D15129.id36528.diff
Wed, Apr 9, 4:08 PM
View All Files
Subscribers
hach-que
Korvin
yelirekim

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPfe5cd4ca2c77: Move FontIcon calls to Icon
Summary

Normalizes all setFontIcon calls to setIcon.

Test Plan

UIExamples, Almanac, Apps list, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 36528.Jan 28 2016, 4:43 PM
chad retitled this revision from to Move FontIcon calls to Icon.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: yelirekim, hach-que, Korvin. · View Herald TranscriptJan 28 2016, 4:43 PM
epriestley accepted this revision.Jan 28 2016, 4:43 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 28 2016, 4:43 PM
Closed by commit rPfe5cd4ca2c77: Move FontIcon calls to Icon (authored by chad, committed by chad). · Explain WhyJan 28 2016, 4:48 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in Z1336: General Chat.Jan 28 2016, 7:21 PM

Large Diff

This large diff affects 144 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
src/
applications/
almanac/
application/
2 lines
controller/
6 lines
audit/
application/
2 lines
auth/
application/
2 lines
badges/
application/
2 lines
query/
2 lines
base/
2 lines
controller/
2 lines
calendar/
application/
2 lines
chatlog/
application/
2 lines
conduit/
application/
2 lines
config/
application/
2 lines
controller/
2 lines
module/
2 lines
option/
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
conpherence/
application/
2 lines
config/
2 lines
countdown/
application/
2 lines
query/
2 lines
daemon/
application/
2 lines
dashboard/
application/
2 lines
controller/
2 lines
query/
2 lines
differential/
application/
2 lines
config/
2 lines
query/
2 lines
diffusion/
application/
2 lines
config/
2 lines
diviner/
application/
2 lines
doorkeeper/
application/
2 lines
option/
2 lines
drydock/
application/
2 lines
controller/
8 lines
fact/
application/
2 lines
feed/
application/
2 lines
config/
2 lines
files/
application/
2 lines
config/
2 lines
query/
2 lines
flag/
application/
2 lines
fund/
application/
2 lines
harbormaster/
application/
2 lines
config/
2 lines
herald/
application/
2 lines
query/
2 lines
home/
application/
2 lines
legalpad/
application/
2 lines
config/
2 lines
query/
2 lines
macro/
application/
2 lines
config/
2 lines
markup/
4 lines
query/
2 lines
maniphest/
application/
2 lines
config/
2 lines
query/
2 lines
meta/
application/
2 lines
query/
2 lines
typeahead/
2 lines
view/
2 lines
metamta/
application/
2 lines
multimeter/
application/
2 lines
notification/
application/
2 lines
nuance/
application/
2 lines
controller/
4 lines
oauthserver/
application/
2 lines
owners/
application/
2 lines
config/
2 lines
query/
2 lines
passphrase/
application/
2 lines
query/
2 lines
paste/
application/
2 lines
config/
2 lines
query/
2 lines
people/
application/
2 lines
config/
2 lines
phame/
application/
2 lines
phid/
type/
2 lines
phlux/
application/
2 lines
pholio/
application/
2 lines
config/
2 lines
query/
2 lines
phortune/
application/
2 lines
phpast/
application/
2 lines
phragment/
application/
2 lines
phrequent/
application/
2 lines
config/
2 lines
phriction/
application/
2 lines
config/
2 lines
phurl/
application/
2 lines
query/
2 lines
policy/
config/
2 lines
ponder/
application/
2 lines
query/
2 lines
project/
application/
2 lines
config/
2 lines
query/
2 lines
releeph/
application/
2 lines
config/
2 lines
repository/
config/
2 lines
query/
2 lines
search/
application/
2 lines
config/
2 lines
settings/
application/
2 lines
panel/
2 lines
slowvote/
application/
2 lines
query/
2 lines
spaces/
application/
2 lines
query/
2 lines
tokens/
application/
2 lines
transactions/
editengine/
2 lines
feed/
2 lines
query/
2 lines
uiexample/
application/
2 lines
examples/
10 lines
4 lines
xhprof/
application/
2 lines
infrastructure/
markup/
rule/
2 lines
view/
page/
2 lines
menu/
2 lines
phui/
2 lines
4 lines
4 lines

Diff 36529

View Options

src/applications/almanac/application/PhabricatorAlmanacApplication.php

View Options

src/applications/almanac/controller/AlmanacConsoleController.php

View Options

src/applications/audit/application/PhabricatorAuditApplication.php

View Options

src/applications/auth/application/PhabricatorAuthApplication.php

View Options

src/applications/badges/application/PhabricatorBadgesApplication.php

View Options

src/applications/badges/query/PhabricatorBadgesSearchEngine.php

View Options

src/applications/base/PhabricatorApplication.php

View Options

src/applications/base/controller/PhabricatorController.php

View Options

src/applications/calendar/application/PhabricatorCalendarApplication.php

View Options

src/applications/chatlog/application/PhabricatorChatLogApplication.php

View Options

src/applications/conduit/application/PhabricatorConduitApplication.php

View Options

src/applications/config/application/PhabricatorConfigApplication.php

View Options

src/applications/config/controller/PhabricatorConfigListController.php

View Options

src/applications/config/module/PhabricatorConfigPHIDModule.php

View Options

src/applications/config/option/PhabricatorAWSConfigOptions.php

View Options

src/applications/config/option/PhabricatorAccessLogConfigOptions.php

View Options

src/applications/config/option/PhabricatorApplicationConfigOptions.php

View Options

src/applications/config/option/PhabricatorAuthenticationConfigOptions.php

View Options

src/applications/config/option/PhabricatorClusterConfigOptions.php

View Options

src/applications/config/option/PhabricatorCoreConfigOptions.php

View Options

src/applications/config/option/PhabricatorDeveloperConfigOptions.php

View Options

src/applications/config/option/PhabricatorExtendingPhabricatorConfigOptions.php

View Options

src/applications/config/option/PhabricatorMailgunConfigOptions.php

View Options

src/applications/config/option/PhabricatorMetaMTAConfigOptions.php

View Options

src/applications/config/option/PhabricatorMySQLConfigOptions.php

View Options

src/applications/config/option/PhabricatorNotificationConfigOptions.php

View Options

src/applications/config/option/PhabricatorPHDConfigOptions.php

View Options

src/applications/config/option/PhabricatorPHPMailerConfigOptions.php

View Options

src/applications/config/option/PhabricatorPhurlConfigOptions.php

View Options

src/applications/config/option/PhabricatorRecaptchaConfigOptions.php

View Options

src/applications/config/option/PhabricatorSMSConfigOptions.php

View Options

src/applications/config/option/PhabricatorSecurityConfigOptions.php

View Options

src/applications/config/option/PhabricatorSendGridConfigOptions.php

View Options

src/applications/config/option/PhabricatorSyntaxHighlightingConfigOptions.php

View Options

src/applications/config/option/PhabricatorTranslationsConfigOptions.php

View Options

src/applications/config/option/PhabricatorUIConfigOptions.php

View Options

src/applications/conpherence/application/PhabricatorConpherenceApplication.php

View Options

src/applications/conpherence/config/ConpherenceConfigOptions.php

View Options

src/applications/countdown/application/PhabricatorCountdownApplication.php

View Options

src/applications/countdown/query/PhabricatorCountdownSearchEngine.php

View Options

src/applications/daemon/application/PhabricatorDaemonsApplication.php

View Options

src/applications/dashboard/application/PhabricatorDashboardApplication.php

View Options

src/applications/dashboard/controller/PhabricatorDashboardPanelListController.php

View Options

src/applications/dashboard/query/PhabricatorDashboardSearchEngine.php

View Options

src/applications/differential/application/PhabricatorDifferentialApplication.php

View Options

src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

View Options

src/applications/diffusion/config/PhabricatorDiffusionConfigOptions.php

View Options

src/applications/diviner/application/PhabricatorDivinerApplication.php

View Options

src/applications/doorkeeper/application/PhabricatorDoorkeeperApplication.php

View Options

src/applications/doorkeeper/option/PhabricatorAsanaConfigOptions.php

View Options

src/applications/drydock/application/PhabricatorDrydockApplication.php

View Options

src/applications/drydock/controller/DrydockConsoleController.php

View Options

src/applications/fact/application/PhabricatorFactApplication.php

View Options

src/applications/feed/application/PhabricatorFeedApplication.php

View Options

src/applications/feed/config/PhabricatorFeedConfigOptions.php

View Options

src/applications/files/application/PhabricatorFilesApplication.php

View Options

src/applications/files/config/PhabricatorFilesConfigOptions.php

View Options

src/applications/files/query/PhabricatorFileSearchEngine.php

View Options

src/applications/flag/application/PhabricatorFlagsApplication.php

View Options

src/applications/fund/application/PhabricatorFundApplication.php

View Options

src/applications/harbormaster/application/PhabricatorHarbormasterApplication.php

View Options

src/applications/harbormaster/config/PhabricatorHarbormasterConfigOptions.php

View Options

src/applications/herald/application/PhabricatorHeraldApplication.php

View Options

src/applications/herald/query/HeraldRuleSearchEngine.php

View Options

src/applications/home/application/PhabricatorHomeApplication.php

View Options

src/applications/legalpad/application/PhabricatorLegalpadApplication.php

View Options

src/applications/legalpad/config/PhabricatorLegalpadConfigOptions.php

View Options

src/applications/legalpad/query/LegalpadDocumentSearchEngine.php

View Options

src/applications/macro/application/PhabricatorMacroApplication.php

View Options

src/applications/macro/config/PhabricatorMacroConfigOptions.php

View Options

src/applications/macro/markup/PhabricatorIconRemarkupRule.php

View Options

src/applications/macro/query/PhabricatorMacroSearchEngine.php

View Options

src/applications/maniphest/application/PhabricatorManiphestApplication.php

View Options

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

View Options

src/applications/maniphest/query/ManiphestTaskSearchEngine.php

View Options

src/applications/meta/application/PhabricatorApplicationsApplication.php

View Options

src/applications/meta/query/PhabricatorAppSearchEngine.php

View Options

src/applications/meta/typeahead/PhabricatorApplicationDatasource.php

View Options

src/applications/meta/view/PhabricatorApplicationLaunchView.php

View Options

src/applications/metamta/application/PhabricatorMetaMTAApplication.php

View Options

src/applications/multimeter/application/PhabricatorMultimeterApplication.php

View Options

src/applications/notification/application/PhabricatorNotificationsApplication.php

View Options

src/applications/nuance/application/PhabricatorNuanceApplication.php

View Options

src/applications/nuance/controller/NuanceConsoleController.php

View Options

src/applications/oauthserver/application/PhabricatorOAuthServerApplication.php

View Options

src/applications/owners/application/PhabricatorOwnersApplication.php

View Options

src/applications/owners/config/PhabricatorOwnersConfigOptions.php

View Options

src/applications/owners/query/PhabricatorOwnersPackageSearchEngine.php

View Options

src/applications/passphrase/application/PhabricatorPassphraseApplication.php

View Options

src/applications/passphrase/query/PassphraseCredentialSearchEngine.php

View Options

src/applications/paste/application/PhabricatorPasteApplication.php

View Options

src/applications/paste/config/PhabricatorPasteConfigOptions.php

View Options

src/applications/paste/query/PhabricatorPasteSearchEngine.php

View Options

src/applications/people/application/PhabricatorPeopleApplication.php

View Options

src/applications/people/config/PhabricatorUserConfigOptions.php

View Options

src/applications/phame/application/PhabricatorPhameApplication.php

View Options

src/applications/phid/type/PhabricatorPHIDType.php

View Options

src/applications/phlux/application/PhabricatorPhluxApplication.php

View Options

src/applications/pholio/application/PhabricatorPholioApplication.php

View Options

src/applications/pholio/config/PhabricatorPholioConfigOptions.php

View Options

src/applications/pholio/query/PholioMockSearchEngine.php

View Options

src/applications/phortune/application/PhabricatorPhortuneApplication.php

View Options

src/applications/phpast/application/PhabricatorPHPASTApplication.php

View Options

src/applications/phragment/application/PhabricatorPhragmentApplication.php

View Options

src/applications/phrequent/application/PhabricatorPhrequentApplication.php

View Options

src/applications/phrequent/config/PhabricatorPhrequentConfigOptions.php

View Options

src/applications/phriction/application/PhabricatorPhrictionApplication.php

View Options

src/applications/phriction/config/PhabricatorPhrictionConfigOptions.php

View Options

src/applications/phurl/application/PhabricatorPhurlApplication.php

View Options

src/applications/phurl/query/PhabricatorPhurlURLSearchEngine.php

View Options

src/applications/policy/config/PhabricatorPolicyConfigOptions.php

View Options

src/applications/ponder/application/PhabricatorPonderApplication.php

View Options

src/applications/ponder/query/PonderQuestionSearchEngine.php

View Options

src/applications/project/application/PhabricatorProjectApplication.php

View Options

src/applications/project/config/PhabricatorProjectConfigOptions.php

View Options

src/applications/project/query/PhabricatorProjectSearchEngine.php

View Options

src/applications/releeph/application/PhabricatorReleephApplication.php

View Options

src/applications/releeph/config/PhabricatorReleephApplicationConfigOptions.php

View Options

src/applications/repository/config/PhabricatorRepositoryConfigOptions.php

View Options

src/applications/repository/query/PhabricatorRepositorySearchEngine.php

View Options

src/applications/search/application/PhabricatorSearchApplication.php

View Options

src/applications/search/config/PhabricatorSearchConfigOptions.php

View Options

src/applications/settings/application/PhabricatorSettingsApplication.php

View Options

src/applications/settings/panel/PhabricatorHomePreferencesSettingsPanel.php

View Options

src/applications/slowvote/application/PhabricatorSlowvoteApplication.php

View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

View Options

src/applications/spaces/application/PhabricatorSpacesApplication.php

View Options

src/applications/spaces/query/PhabricatorSpacesNamespaceSearchEngine.php

View Options

src/applications/tokens/application/PhabricatorTokensApplication.php

View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

View Options

src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php

View Options

src/applications/transactions/query/PhabricatorEditEngineSearchEngine.php

View Options

src/applications/uiexample/application/PhabricatorUIExamplesApplication.php

View Options

src/applications/uiexample/examples/PHUIActionPanelExample.php

View Options

src/applications/uiexample/examples/PHUIIconExample.php

View Options

src/applications/xhprof/application/PhabricatorXHProfApplication.php

View Options

src/infrastructure/markup/rule/PhabricatorNavigationRemarkupRule.php

View Options

src/view/page/PhabricatorStandardPageView.php

View Options

src/view/page/menu/PhabricatorMainMenuSearchView.php

View Options

src/view/phui/PHUIActionPanelView.php

View Options

src/view/phui/PHUIIconView.php

View Options

src/view/phui/PHUIObjectItemView.php

Phabricator · Built by Phacility