Differential D15089

Give profile menus more straightforward hide/disable/delete/default interactions
ClosedPublic
Actions

Authored by epriestley on Jan 22 2016, 1:58 PM.

Tags

None

Referenced Files

	F13265339: D15089.id.diff
	Tue, May 28, 3:23 AM

	F13252689: D15089.id36430.diff
	Sat, May 25, 1:58 AM

	F13213923: D15089.diff
	Fri, May 17, 8:14 AM

	F13191642: D15089.id36439.diff
	Sat, May 11, 11:09 PM

	F13191641: D15089.id36430.diff
	Sat, May 11, 11:09 PM

	F13191637: D15089.id.diff
	Sat, May 11, 11:08 PM

	Unknown Object (File)
	Tue, May 7, 9:28 AM

	Unknown Object (File)
	Sat, May 4, 3:34 PM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10054: Define product direction for Project/Profile UIs

Commits

Restricted Diffusion Commit
rP51ed95c00b8d: Give profile menus more straightforward hide/disable/delete/default interactions

Summary

Just let users delete non-builtin items.
Let users choose a default item explicitly.
Do a better job of cleaning up items which no longer exist or belong to uninstalled applications.

This has one user-facing change: workboards are no longer the default on projects with workboards. I think this is probably OK since we're giving users a ton of new toys at the same time, but I'll write some docs at least.

Test Plan

Deleted custom items.
Disabled/enabled builtin items.
Made various things defaults.
Uninstalled Maniphest, saw Workboards tab disappear entirely.

Diff Detail

Repository

Branch

pmenudefault

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10266
Build 12493: Run Core Tests
Build 12492: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36430.Jan 22 2016, 1:58 PM

epriestley retitled this revision from to Give profile menus more straightforward hide/disable/delete/default interactions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10054: Define product direction for Project/Profile UIs.

chad accepted this revision.Jan 22 2016, 2:58 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 22 2016, 2:58 PM

epriestley mentioned this in T6961: Rendering of workboard columns on card objects could be marginally more efficient.Jan 22 2016, 4:04 PM

Closed by commit rP51ed95c00b8d: Give profile menus more straightforward hide/disable/delete/default interactions (authored by epriestley, committed by epriestley). · Explain WhyJan 22 2016, 4:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

PhabricatorApplication.php

1 line

project/

controller/

PhabricatorProjectBoardViewController.php

11 lines

PhabricatorProjectViewController.php

17 lines

profilepanel/

PhabricatorProjectDetailsProfilePanel.php

5 lines

PhabricatorProjectWorkboardProfilePanel.php

5 lines

search/

engine/

PhabricatorProfilePanelEngine.php

239 lines

profilepanel/

PhabricatorProfilePanel.php

5 lines

storage/

PhabricatorProfilePanelConfiguration.php

16 lines

Diff 36430

src/applications/base/PhabricatorApplication.php

Loading...

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...

src/applications/project/controller/PhabricatorProjectViewController.php

Loading...

src/applications/project/profilepanel/PhabricatorProjectDetailsProfilePanel.php

Loading...

src/applications/project/profilepanel/PhabricatorProjectWorkboardProfilePanel.php

Loading...

src/applications/search/engine/PhabricatorProfilePanelEngine.php

Loading...

src/applications/search/profilepanel/PhabricatorProfilePanel.php

Loading...

src/applications/search/storage/PhabricatorProfilePanelConfiguration.php

Loading...