Page MenuHomePhabricator

Distinguish more carefully between different kinds of MySQL connection errors
ClosedPublic

Authored by epriestley on Jan 21 2016, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 5:52 AM
Unknown Object (File)
Wed, Oct 23, 8:53 AM
Unknown Object (File)
Oct 18 2024, 5:29 PM
Unknown Object (File)
Oct 13 2024, 8:11 PM
Unknown Object (File)
Oct 1 2024, 12:44 AM
Unknown Object (File)
Sep 24 2024, 9:44 PM
Unknown Object (File)
Sep 21 2024, 10:10 AM
Unknown Object (File)
Sep 19 2024, 2:23 PM
Subscribers
None

Details

Summary

Ref T10195. Root issue: if the MySQL user doesn't have permission to access all the databases, we give them a fairly generic error instead of telling them exactly what's wrong.

Currently, we throw a generic exception on connection failure. Instead, throw a more granular one, and distinguish between bad credentials and no access.

Test Plan

See next revision.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Distinguish more carefully between different kinds of MySQL connection errors.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 21 2016, 8:59 PM
This revision was automatically updated to reflect the committed changes.