Page MenuHomePhabricator

Distinguish more carefully between different kinds of MySQL connection errors
ClosedPublic

Authored by epriestley on Jan 21 2016, 8:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 11, 7:40 PM
Unknown Object (File)
Mon, Mar 11, 6:01 PM
Unknown Object (File)
Mon, Mar 11, 5:49 PM
Unknown Object (File)
Mon, Mar 11, 5:19 PM
Unknown Object (File)
Mon, Mar 11, 4:10 PM
Unknown Object (File)
Fri, Mar 8, 1:56 PM
Unknown Object (File)
Thu, Mar 7, 10:56 PM
Unknown Object (File)
Tue, Mar 5, 5:28 PM
Subscribers
None

Details

Summary

Ref T10195. Root issue: if the MySQL user doesn't have permission to access all the databases, we give them a fairly generic error instead of telling them exactly what's wrong.

Currently, we throw a generic exception on connection failure. Instead, throw a more granular one, and distinguish between bad credentials and no access.

Test Plan

See next revision.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Distinguish more carefully between different kinds of MySQL connection errors.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 21 2016, 8:59 PM
This revision was automatically updated to reflect the committed changes.