Page MenuHomePhabricator
Differential D15028

Add PHIDType for HeraldTransaction
ClosedPublic
Actions

Authored by avivey on Jan 15 2016, 3:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 7:55 PM
Unknown Object (File)
Tue, Dec 17, 7:55 PM
Unknown Object (File)
Thu, Dec 12, 5:44 PM
Unknown Object (File)
Thu, Dec 12, 8:30 AM
Unknown Object (File)
Wed, Dec 11, 12:59 AM
Unknown Object (File)
Sat, Dec 7, 5:37 PM
Unknown Object (File)
Fri, Dec 6, 10:57 AM
Unknown Object (File)
Nov 12 2024, 7:13 AM
View All Files
Subscribers
chad
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess
Commits
Restricted Diffusion Commit
rPeac1124bd954: (stable) Promote 2016 Week 3
rPaadc1b7bf024: Add PHIDType for HeraldTransaction
Test Plan

Paste a HLXS phid to the quick-search box, get transaction page.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10130
Build 12290: Run Core Tests
Build 12289: arc lint + arc unit

Event Timeline

avivey updated this revision to Diff 36287.Jan 15 2016, 3:22 AM
avivey retitled this revision from to Add PHIDType for HeraldTransaction.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptJan 15 2016, 3:22 AM
Herald added a subscriber: epriestley. · View Herald Transcript
avivey updated this revision to Diff 36288.Jan 15 2016, 3:24 AM
avivey edited edge metadata.

Use PHIDType in generatePHID()

epriestley accepted this revision.Jan 15 2016, 4:19 AM
epriestley added a reviewer: epriestley.
epriestley added inline comments.
src/applications/herald/phid/HeraldTranscriptPHIDType.php
38–39

pht() the human-readable text, no need to set a full name if the normal name is the same (it falls back properly).

This revision is now accepted and ready to land.Jan 15 2016, 4:19 AM
avivey updated this revision to Diff 36298.Jan 15 2016, 4:40 PM
avivey edited edge metadata.

pht handle name

Herald added a subscriber: Korvin. · View Herald TranscriptJan 15 2016, 4:40 PM
Closed by commit rPaadc1b7bf024: Add PHIDType for HeraldTransaction (authored by avivey, committed by avivey). · Explain WhyJan 15 2016, 4:40 PM
This revision was automatically updated to reflect the committed changes.
chad added a subscriber: chad.Jan 15 2016, 4:41 PM

itsawesome

epriestley added a task: T9719: Herald test console doesn't appear to work for commit hooks (pre-receive), and also has a big `instanceof` mess.Aug 1 2016, 6:31 PM

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
herald/
phid/
42 lines
query/
13 lines
storage/
transcript/
3 lines

Diff 36298

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/phid/HeraldTranscriptPHIDType.php

Loading...
View Options

src/applications/herald/query/HeraldTranscriptQuery.php

Loading...
View Options

src/applications/herald/storage/transcript/HeraldTranscript.php

Loading...
Phabricator · Built by Phacility