Page MenuHomePhabricator

Add PHIDType for HeraldTransaction
ClosedPublic

Authored by avivey on Jan 15 2016, 3:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 19, 8:25 AM
Unknown Object (File)
Fri, Mar 8, 1:07 PM
Unknown Object (File)
Fri, Mar 8, 1:06 PM
Unknown Object (File)
Tue, Mar 5, 7:13 PM
Unknown Object (File)
Tue, Mar 5, 7:12 PM
Unknown Object (File)
Tue, Mar 5, 7:12 PM
Unknown Object (File)
Tue, Mar 5, 7:10 AM
Unknown Object (File)
Tue, Mar 5, 7:10 AM

Details

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey retitled this revision from to Add PHIDType for HeraldTransaction.
avivey updated this object.
avivey edited the test plan for this revision. (Show Details)
avivey edited edge metadata.

Use PHIDType in generatePHID()

epriestley added a reviewer: epriestley.
epriestley added inline comments.
src/applications/herald/phid/HeraldTranscriptPHIDType.php
38–39

pht() the human-readable text, no need to set a full name if the normal name is the same (it falls back properly).

This revision is now accepted and ready to land.Jan 15 2016, 4:19 AM
avivey edited edge metadata.

pht handle name

This revision was automatically updated to reflect the committed changes.